Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: make IDEA support IssueNavigationLink #600

Merged
merged 2 commits into from
Apr 14, 2024
Merged

chore: make IDEA support IssueNavigationLink #600

merged 2 commits into from
Apr 14, 2024

Conversation

liuxiaocs7
Copy link
Member

@liuxiaocs7 liuxiaocs7 commented Apr 13, 2024 •
edited
Loading

Purpose of the PR

before:
Snipaste_2024-04-13_19-00-03
after:
Snipaste_2024-04-13_19-14-28

Main Changes

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Apr 13, 2024
javeme
javeme approved these changes Apr 13, 2024
View reviewed changes
Copy link
Contributor

@javeme javeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 13, 2024
imbajin
imbajin approved these changes Apr 14, 2024
View reviewed changes
.idea/vcs.xml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VGalaxies seems we could also enable it in other repos?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in: apache/incubator-hugegraph#2521
Note: drop incubator- in url https://github.com/apache/incubator-hugegraph-toolchain/pull/$1 next time like apache/incubator-hugegraph#2521

@liuxiaocs7 liuxiaocs7 merged commit ef68cc5 into apache:master Apr 14, 2024
8 checks passed
@liuxiaocs7 liuxiaocs7 mentioned this pull request Apr 14, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imbajin imbajin imbajin approved these changes

@javeme javeme javeme approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liuxiaocs7 @javeme @imbajin