Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: intro editorconfig-maven-plugin for verifying code style defined in .editorconfig #614

Merged
merged 4 commits into from
Jul 23, 2024

Conversation

HJ-Young
Copy link
Contributor

refer to PR#2591

  • check code style during the verify phase of the build
  • use mvn editorconfig:format for one-click code formatting

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. ci Continuous integration labels Jul 17, 2024
@VGalaxies VGalaxies self-assigned this Jul 17, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jul 20, 2024
@github-actions github-actions bot added hubble hugegraph-hubble loader hugegraph-loader client hugegraph-client tools hugegraph-tools labels Jul 20, 2024
Copy link

codecov bot commented Jul 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.10%. Comparing base (b066b80) to head (4e03243).
Report is 35 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #614      +/-   ##
============================================
- Coverage     62.49%   62.10%   -0.39%     
+ Complexity     1903      932     -971     
============================================
  Files           262       93     -169     
  Lines          9541     4550    -4991     
  Branches        886      532     -354     
============================================
- Hits           5963     2826    -3137     
+ Misses         3190     1513    -1677     
+ Partials        388      211     -177     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pom.xml Outdated Show resolved Hide resolved
.idea/vcs.xml Outdated Show resolved Hide resolved
@HJ-Young HJ-Young force-pushed the code-style-checker branch from 4e03243 to c4b624e Compare July 20, 2024 15:05
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Jul 20, 2024
@github-actions github-actions bot removed hubble hugegraph-hubble loader hugegraph-loader client hugegraph-client tools hugegraph-tools labels Jul 20, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jul 20, 2024
@github-actions github-actions bot added hubble hugegraph-hubble loader hugegraph-loader client hugegraph-client tools hugegraph-tools labels Jul 20, 2024
@VGalaxies VGalaxies requested a review from imbajin July 21, 2024 11:58
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 22, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file separator diff?

like CRLF -> LF?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed so

@VGalaxies VGalaxies merged commit e94eee1 into apache:master Jul 23, 2024
14 checks passed
@VGalaxies VGalaxies changed the title chore: intro editorconfig-maven-plugin for verifying code style defined in .editorconfig chore: intro editorconfig-maven-plugin for verifying code style defined in .editorconfig Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration client hugegraph-client hubble hugegraph-hubble lgtm This PR has been approved by a maintainer loader hugegraph-loader size:L This PR changes 100-499 lines, ignoring generated files. tools hugegraph-tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants