Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(github): remove centos7 on git action #2137

Closed
wants to merge 2 commits into from
Closed

fix(github): remove centos7 on git action #2137

wants to merge 2 commits into from

Conversation

shalk
Copy link
Collaborator

@shalk shalk commented Oct 21, 2024 •
edited
Loading

What problem does this PR solve?

fix #2135

What is changed and how does it work?

Checklist

Tests
  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code
Code changes
  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change
Side effects
  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility
Related changes
  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

@shalk shalk changed the title remove centos7 on git action fix(github): remove centos7 on git action Oct 21, 2024
@acelyc111
Copy link
Member

acelyc111 commented Oct 22, 2024 •
edited
Loading

@shalk Thanks for the contribution!

As CentOS 7 is widely used and EOL for only 3 months, it's not good to terminate the supporting right now. If do it like this, some build and runtime issues may occurs, we may got complains in the community.

@shalk
Copy link
Collaborator Author

shalk commented Oct 22, 2024 •
edited
Loading

The CenOS 7 Dockerfile can not work anymore. docker pull will fail.

I think almalinux or rockylinux is a alternative for centos7.

@shalk shalk closed this Nov 14, 2024
@acelyc111 acelyc111 mentioned this pull request Nov 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docker docs github
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Workflows failed due to EOL of CentOS 7
2 participants
@shalk @acelyc111