Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:Reclaim the heartbeat response message to avoid memory leakage of GettyRemoting.futures #665

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix:Reclaim the heartbeat response message to avoid memory leakage of GettyRemoting.futures #665

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
14ddd1d
fix:回收心跳response消息，以避免GettyRemoting.futures内存泄露
tanzegen Jan 11, 2024
192c030
remove chinese comment
luky116 Feb 3, 2024
356bac6
Merge branch 'master' into removeComment
lovepoem Oct 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/remoting/processor/client/client_heart_beat_processon.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,5 +38,9 @@ func (f *clientHeartBeatProcessor) Process(ctx context.Context, rpcMessage messa
log.Debug("received PONG from {}", ctx)
}
}
msgFuture := getty.GetGettyRemotingInstance().GetMessageFuture(rpcMessage.ID)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use defer or better?

if msgFuture != nil {
getty.GetGettyRemotingInstance().RemoveMessageFuture(rpcMessage.ID)
}
return nil
}
Loading