Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nacos feature branch #683

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

GoGoGoFast
Copy link

What this PR does:

This pull request integrates the Nacos registry center into the Seata-Go project. The integration includes the following functionalities:

  • Service Registration: Allows services to be registered with Nacos.
  • Service Deregistration: Handles service deregistration from Nacos.
  • Service Lookup: Facilitates querying for registered services.
  • Service Subscription: Enables subscription to service updates.

Which issue(s) this PR fixes:
Fixes # (insert issue number or link)

Special notes for your reviewer:
The integration has been tested and confirmed to work for registration, deregistration, lookup, and subscription functionalities. However, I am currently unsure about the best approach to obtain and provide the local IP address and port of the Seata-Go instance for registration with Nacos. Your guidance on how to fetch and use this information would be greatly appreciated.

Does this PR introduce a user-facing change?:
No.

NONE

Copy link

sonarcloud bot commented Sep 16, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants