Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-10289][Agent] Update the SQLServer Source #10735

Merged
merged 4 commits into from
Aug 2, 2024

Conversation

zoy0
Copy link
Contributor

@zoy0 zoy0 commented Jul 30, 2024

Fixes #10289

Motivation

Update the SQLServer Source for agent

Modifications

Start a Debezium thread to collect change data from SQLServer and convert time fields to string. Then put sourceData into a queue. The agent will regularly read data from this queue and send it to DataProxy.

Verifying this change

image

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @zoy0, thank you for submitting a PR to InLong 💖 We will respond as soon as possible ⏳
This seems to be your first PR 🌠 Please be sure to follow our Contribution Guidelines.
If you have any questions in the meantime, you can also ask us on the InLong Discussions 🔍

@dockerzhang
Copy link
Contributor

Run 'mvn spotless:apply' to fix these violations.

@zoy0
Copy link
Contributor Author

zoy0 commented Jul 30, 2024

Run 'mvn spotless:apply' to fix these violations.

done

@dockerzhang
Copy link
Contributor

@zoy0 please click resolve if you fixed the comments.

@aloyszhang
Copy link
Contributor

please rebase the master to resolve conflicting files

@zoy0
Copy link
Contributor Author

zoy0 commented Jul 31, 2024

please rebase the master to resolve conflicting files

done

@zoy0 zoy0 requested a review from justinwwhuang July 31, 2024 06:40
@dockerzhang
Copy link
Contributor

@haifxu @justinwwhuang PTAL, thanks.

Copy link
Contributor

@justinwwhuang justinwwhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dockerzhang dockerzhang merged commit 590e46e into apache:master Aug 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve][Agent] Update the SQLServer Source
5 participants