Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-7940][Sort] Use pulsar subscriptions and specify subscription offset in pulsar connector #7943

Merged
merged 2 commits into from
May 8, 2023

Conversation

EMsnap
Copy link
Contributor

@EMsnap EMsnap commented Apr 27, 2023

Prepare a Pull Request

Motivation

[INLONG-7940][Manager] Use pulsar subscriptions and specify subscription offset in pulsar connector

Modifications

[INLONG-7940][Manager] Use pulsar subscriptions and specify subscription offset in pulsar connector

See SCAN_STARTUP_SUB_START_OFFSET SCAN_STARTUP_SUB_NAME SCAN_STARTUP_MODE in PulsarTableOptions

Documentation

  • Does this pull request introduce a new feature? (no)

@EMsnap EMsnap marked this pull request as draft April 27, 2023 09:22
@EMsnap EMsnap marked this pull request as ready for review May 6, 2023 09:10
@EMsnap EMsnap marked this pull request as draft May 8, 2023 02:12
@EMsnap
Copy link
Contributor Author

EMsnap commented May 8, 2023

wait for #7937 to be merged first

@EMsnap EMsnap changed the title [INLONG-7940][Manager] Use pulsar subscriptions and specify subscription offset in pulsar connector [INLONG-7940][Sort] Use pulsar subscriptions and specify subscription offset in pulsar connector May 8, 2023
@EMsnap EMsnap marked this pull request as ready for review May 8, 2023 03:25
@gong
Copy link
Contributor

gong commented May 8, 2023

@EMsnap This feature just can be used when pulsar admin api is supportted. Maybe, for without pulsar admin api situation, inlong manager can't distribute new params to support this feature.

@EMsnap
Copy link
Contributor Author

EMsnap commented May 8, 2023

@EMsnap This feature just can be used when pulsar admin api is supportted. Maybe, for without pulsar admin api situation, inlong manager can't distribute new params to support this feature.

If there is no admin url the parameter won't be used since there is a seperate source for pulsar without admin

@EMsnap EMsnap merged commit 13909ba into apache:master May 8, 2023
GanfengTan pushed a commit to GanfengTan/incubator-inlong that referenced this pull request May 10, 2023
@EMsnap EMsnap deleted the 7940 branch May 30, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][Manager][Sort] Use Pulsar subscriptions in Pulsar connector
4 participants