Store the MPU ETag for the transient blobstore #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaul
reviewed
Aug 4, 2021
| if (blob.getMetadata() != null) { | ||
| eTag = blob.getMetadata().getETag(); | ||
| } | ||
| if (eTag == null || !MPU_ETAG_FORMAT.matcher(eTag).matches()) { |
There was a problem hiding this comment.
Why does this need to sanity check the format? Is there a danger to allowing an arbitrary input?
There was a problem hiding this comment.
That's fair. Removed the format check.
JCLOUDS-1582: fixes a bug in the transient blobstore where after uploading a multipart upload, GET/HEAD returns the hash of the content, rather than the MPU ETag.
timuralp
force-pushed
the
bug/transient-mpu-etag
branch
from
2781469
to
6f35843
Compare
|
Thank you for your contribution @timuralp! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JCLOUDS-1582: fixes a bug in the transient blobstore where after
uploading a multipart upload, GET/HEAD returns the hash of the content,
rather than the MPU ETag.