Skip to content

KAFKA-12701: NPE in MetadataRequest when using topic IDs#10885

Merged
ijuma merged 2 commits intoapache:2.8from
jolshan:KAFKA-12701-2.8
Jun 15, 2021
Merged

KAFKA-12701: NPE in MetadataRequest when using topic IDs#10885
ijuma merged 2 commits intoapache:2.8from
jolshan:KAFKA-12701-2.8

Conversation

@jolshan
Copy link
Member

@jolshan jolshan commented Jun 15, 2021

cherry-pick of c16711c
Updated KafkaApisTest to use 2.8 code.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

jolshan added 2 commits June 15, 2021 08:48
We prevent handling MetadataRequests where the topic name is null (to prevent NPE) as
well as prevent requests that set topic IDs since this functionality has not yet been
implemented. When we do implement it  in apache#9769,
we should bump the request/response version.

Added tests to ensure the error is thrown.

Reviewers: dengziming <swzmdeng@163.com>, Ismael Juma <ismael@juma.me.uk>
Copy link
Member

@ijuma ijuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the tests pass.

@ijuma
Copy link
Member

ijuma commented Jun 15, 2021

Unrelated failures:

Build / JDK 15 and Scala 2.13 / kafka.server.ListOffsetsRequestTest.testResponseIncludesLeaderEpoch()
Build / JDK 11 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationSSLTest.testOneWayReplicationWithAutoOffsetSync()
Build / JDK 11 and Scala 2.13 / org.apache.kafka.connect.integration.RebalanceSourceConnectorsIntegrationTest.testMultipleWorkersRejoining
Build / JDK 11 and Scala 2.13 / kafka.api.TransactionsBounceTest.testWithGroupId()
Build / JDK 11 and Scala 2.13 / kafka.network.DynamicConnectionQuotaTest.testDynamicListenerConnectionCreationRateQuota()

@ijuma ijuma merged commit a6954a0 into apache:2.8 Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments