From 2ea700083c6494fc5ca68b3c2008319eb233b76a Mon Sep 17 00:00:00 2001 From: Binbin Date: Thu, 3 Aug 2023 23:48:33 +0800 Subject: [PATCH] code review from twice, thanks a lot --- src/types/redis_string.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/types/redis_string.cc b/src/types/redis_string.cc index 14f53f18731..581652895ab 100644 --- a/src/types/redis_string.cc +++ b/src/types/redis_string.cc @@ -386,7 +386,7 @@ rocksdb::Status String::MSet(const std::vector &pairs, uint64_t ttl, batch->Put(metadata_cf_handle_, ns_key, bytes); std::optional guard; if (lock) { - guard(storage_->GetLockManager(), ns_key); + guard.emplace(storage_->GetLockManager(), ns_key); } auto s = storage_->Write(storage_->DefaultWriteOptions(), batch->GetWriteBatch()); if (!s.ok()) return s;