diff --git a/src/cluster.cc b/src/cluster.cc index 7a6c0003a35..0d5c454ac03 100644 --- a/src/cluster.cc +++ b/src/cluster.cc @@ -507,7 +507,7 @@ Status Cluster::ParseClusterNodes(const std::string &nodes_str, ClusterNodes *no nodes->clear(); // Parse all nodes - for (const auto& node_str : nodes_info) { + for (const auto &node_str : nodes_info) { std::vector fields = Util::Split(node_str, " "); if (fields.size() < 5) { return Status(Status::ClusterInvalidInfo, "Invalid cluster nodes info"); diff --git a/src/config.cc b/src/config.cc index e3a7c574bd0..4151620cb39 100644 --- a/src/config.cc +++ b/src/config.cc @@ -262,7 +262,7 @@ void Config::initFieldValidator() { return Status::OK(); }}, }; - for (const auto& iter : validators) { + for (const auto &iter : validators) { auto field_iter = fields_.find(iter.first); if (field_iter != fields_.end()) { field_iter->second->validate = iter.second; @@ -479,7 +479,7 @@ void Config::initFieldCallback() { {"rocksdb.level0_stop_writes_trigger", set_cf_option_cb}, {"rocksdb.level0_file_num_compaction_trigger", set_cf_option_cb} }; - for (const auto& iter : callbacks) { + for (const auto &iter : callbacks) { auto field_iter = fields_.find(iter.first); if (field_iter != fields_.end()) { field_iter->second->callback = iter.second; diff --git a/src/server.cc b/src/server.cc index 9139a857dd0..9fcc82fc9f1 100644 --- a/src/server.cc +++ b/src/server.cc @@ -117,7 +117,7 @@ Status Server::Start() { } } - for (const auto& worker : worker_threads_) { + for (const auto &worker : worker_threads_) { worker->Start(); } task_runner_.Start(); @@ -171,7 +171,7 @@ Status Server::Start() { void Server::Stop() { stop_ = true; if (replication_thread_) replication_thread_->Stop(); - for (const auto& worker : worker_threads_) { + for (const auto &worker : worker_threads_) { worker->Stop(); } DisconnectSlaves(); @@ -180,7 +180,7 @@ void Server::Stop() { } void Server::Join() { - for (const auto& worker : worker_threads_) { + for (const auto &worker : worker_threads_) { worker->Join(); } task_runner_.Join(); diff --git a/tests/cppunit/rwlock_test.cc b/tests/cppunit/rwlock_test.cc index 4d4d7393a11..4c6ef90ce1c 100644 --- a/tests/cppunit/rwlock_test.cc +++ b/tests/cppunit/rwlock_test.cc @@ -27,7 +27,7 @@ TEST(LockManager, LockKey) { LockManager locks(8); std::vector keys = {"abc", "123", "456", "abc", "123"}; - for (const auto key : keys) { + for (const auto &key : keys) { locks.Lock(key); locks.UnLock(key); } diff --git a/tests/cppunit/t_string_test.cc b/tests/cppunit/t_string_test.cc index b3d02747912..2848d8ac70f 100644 --- a/tests/cppunit/t_string_test.cc +++ b/tests/cppunit/t_string_test.cc @@ -75,7 +75,7 @@ TEST_F(RedisStringTest, MGetAndMSet) { string->MSet(pairs_); std::vector keys; std::vector values; - for (const auto pair : pairs_) { + for (const auto &pair : pairs_) { keys.emplace_back(pair.key); } string->MGet(keys, &values); @@ -178,7 +178,7 @@ TEST_F(RedisStringTest, MSetNX) { EXPECT_EQ(1, ret); std::vector keys; std::vector values; - for (const auto pair : pairs_) { + for (const auto &pair : pairs_) { keys.emplace_back(pair.key); } string->MGet(keys, &values);