Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cmd): add more information to shutdown log #2672

Merged
merged 2 commits into from
Nov 19, 2024
Merged

feat(cmd): add more information to shutdown log #2672

merged 2 commits into from
Nov 19, 2024

Conversation

PragmaTwice
Copy link
Member

"Bye bye" seems useless and doesn't contain any information.

PragmaTwice
PragmaTwice commented Nov 19, 2024
View reviewed changes
src/cli/main.cc Outdated Show resolved Hide resolved
torwig
torwig approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@torwig torwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ()

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
60.7% Coverage on New Code
1.3% Duplication on New Code

See analysis details on SonarQube Cloud

@PragmaTwice PragmaTwice merged commit f98cb0c into apache:unstable Nov 19, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mapleFU mapleFU mapleFU approved these changes

@torwig torwig torwig approved these changes

@git-hulk git-hulk git-hulk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PragmaTwice @git-hulk @torwig @mapleFU