Add the redis.log function in Lua script #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We implement the builtin function `redis.log()` for the Lua script, but the log level was different between Redis and Kvrocks, so we choose to keep consistency with Redis's log level to avoid compatible problem with below mappings(which would make the legacy script happy): LOG_DEBUG => NULL LOG_VERBOSE => INFO LOG_NOTICE => INFO LOG_WARNING => WARNING LOG_DEBUG would never work since the debug level make no sense in kvrocks
ShooterIT
approved these changes
Nov 1, 2021
ShooterIT
pushed a commit
to ShooterIT/kvrocks
that referenced
this pull request
Nov 2, 2021
We implement the builtin function `redis.log()` for the Lua script, but the log level was different between Redis and Kvrocks, so we choose to keep consistency with Redis's log level to avoid compatible problem with below mappings(which would make the legacy script happy): LOG_DEBUG => NULL LOG_VERBOSE => INFO LOG_NOTICE => INFO LOG_WARNING => WARNING LOG_DEBUG would never work since the debug level make no sense in kvrocks
ShooterIT
pushed a commit
that referenced
this pull request
Nov 2, 2021
We implement the builtin function `redis.log()` for the Lua script, but the log level was different between Redis and Kvrocks, so we choose to keep consistency with Redis's log level to avoid compatible problem with below mappings(which would make the legacy script happy): LOG_DEBUG => NULL LOG_VERBOSE => INFO LOG_NOTICE => INFO LOG_WARNING => WARNING LOG_DEBUG would never work since the debug level make no sense in kvrocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We implement the builtin function
redis.log()for the Lua script,but the log level was different between Redis and Kvrocks, so we
choose to keep consistency with Redis's log level to avoid compatible
problem with the below mappings(which would make the legacy script happy):
LOG_DEBUG => NULL
LOG_VERBOSE => INFO
LOG_NOTICE => INFO
LOG_WARNING => WARNING
LOG_DEBUG would never work since the debug level make no sense in kvrocks