[KYUUBI #2484] Add conf to SessionEvent and display it in EngineSessionPage #2485
Conversation
| username: String, | ||
| ip: String, | ||
| serverIp: String, | ||
| conf: Map[String, String], |
There was a problem hiding this comment.
I think this is connection initializing config map, how about the configs from set command
There was a problem hiding this comment.
I think this is connection initializing config map, how about the configs from
setcommand
The set statement will be displayed in the statement list, we don't need to override it here, it might be better to show the initial configurations.
There was a problem hiding this comment.
Yes, can't agree more. Comment on purpose 😁
| Session created at {formatDate(sessionStat.startTime)}, | ||
| Total run {sessionStat.totalOperations} SQL | ||
| </h4> ++ | ||
| sessionPropertiesTable ++ |
There was a problem hiding this comment.
Is it better to be shown after SQL stats?
There was a problem hiding this comment.
Is it better to be shown after SQL stats?
I think it would be better to put this in front of SQL stats as part of the details of the session.
There was a problem hiding this comment.
OK, let keep it before SQL stats
Codecov Report
@@ Coverage Diff @@
## master #2485 +/- ##
============================================
- Coverage 63.45% 63.37% -0.08%
Complexity 69 69
============================================
Files 371 371
Lines 17585 17608 +23
Branches 2348 2348
============================================
+ Hits 11158 11159 +1
- Misses 5392 5416 +24
+ Partials 1035 1033 -2
Continue to review full report at Codecov.
|
Thanks, I'll add it later |
|
nice feature, thanks |
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/spark/ui/EngineSessionPage.scala
Outdated
Show resolved
Hide resolved
…onPage ### _Why are the changes needed?_ close #2484 ### _How was this patch tested?_ - [X] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [X] Add screenshots for manual tests if appropriate  - [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request Closes #2485 from wForget/KYUUBI-2484. Closes #2484 b527cae [wforget] sorted 88a0282 [wforget] add test 5c3bb30 [wforget] [KYUUBI-2484] Add conf to SessionEvent and display it in EngineSessionPage Authored-by: wforget <643348094@qq.com> Signed-off-by: Fei Wang <fwang12@ebay.com> (cherry picked from commit 06da8cf) Signed-off-by: Fei Wang <fwang12@ebay.com>
|
thanks, merged to master and branch-1.5 |
7 participants
Why are the changes needed?
close #2484
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request