From 05e47ad0004ed630ab57aa64891c863e2b298a33 Mon Sep 17 00:00:00 2001 From: Luca Cavanna Date: Fri, 6 Sep 2024 20:29:35 +0200 Subject: [PATCH] iter --- lucene/CHANGES.txt | 3 +++ lucene/MIGRATE.md | 7 +++++++ 2 files changed, 10 insertions(+) diff --git a/lucene/CHANGES.txt b/lucene/CHANGES.txt index 42ab9c6fc635..12f7b960ccb3 100644 --- a/lucene/CHANGES.txt +++ b/lucene/CHANGES.txt @@ -114,6 +114,9 @@ API Changes * GITHUB#13708: Move Operations.sameLanguage/subsetOf to test-framework. (Robert Muir) +* GITHUB#13733: Move FacetsCollector#search utility methods to `FacetsCollectorManager`, replace the `Collector` + argument with a `FacetsCollectorManager` and update the return type to include both `TopDocs` results as well as + facets results. (Luca Cavanna) New Features --------------------- diff --git a/lucene/MIGRATE.md b/lucene/MIGRATE.md index cebc479aa243..cf881faa5d4f 100644 --- a/lucene/MIGRATE.md +++ b/lucene/MIGRATE.md @@ -793,6 +793,13 @@ Specifically, the method `FunctionValues#getScorer(Weight weight, LeafReaderCont Callers must now keep track of the Weight instance that created the Scorer if they need it, instead of relying on Scorer. +### `FacetsCollector#search` utility methods moved and updated + +The static `search` methods exposed by `FacetsCollector` have been moved to `FacetsCollectorManager`. +Furthermore, they take a `FacetsCollectorManager` last argument in place of a `Collector` so that they support +intra query concurrency. The return type has also be updated to `FacetsCollectorManager.FacetsResult` which includes +both `TopDocs` as well as facets results included in a reduced `FacetsCollector` instance. + ### `SearchWithCollectorTask` no longer supports the `collector.class` config parameter `collector.class` used to allow users to load a custom collector implementation. `collector.manager.class`