Fix Flaky Test In TestBlockJoinBulkScorer #13785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpountz
reviewed
Sep 16, 2024
lucene/join/src/test/org/apache/lucene/search/join/TestBlockJoinBulkScorer.java
Show resolved
Hide resolved
| assertEquals(expectedScoresList.getFirst(), actualScores); | ||
| } else { | ||
| assertEqualsToOneOf(expectedScoresList, actualScores); | ||
| } |
There was a problem hiding this comment.
I'm curious why you don't call assertEqualsToOneOf all the time, shouldn't it also work in the size==1 case?
There was a problem hiding this comment.
It should and I originally did that, but if you use assertEquals there are nicer IDE integrations for value comparison on failure. Given that this method is called with a single map of expected scores in nearly all cases, I tried to preserve that functionality. This could help in the case of a failure in testScoreRandomIndices, which could have a large random score map.
|
Thanks for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the
testSetMinCompetitiveScoreWithScoreModeMaxtest, which sometimes failed due to randomizations in how the docs were scored. This fix should also be backported tobranch_9x.