Upgrade to Maven 4.0.0-rc-4 and editions #481
Conversation
…s deprecated since Maven 3.0.0.
src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java
Outdated
Show resolved
Hide resolved
|
We have an approval and I saw no objection. Should we process with the merge? |
This commit should not change the behaviour of the Maven JAR plugin, except when a null argument is given to `getJarFile` in which case the `IllegalArgumentException` has been replaced by `NullPointerException`.
desruisseaux
force-pushed
the
upgrade-and-editions
branch
from
b065aa2 to
a2932ac
Compare
|
@desruisseaux Please assign appropriate label to PR according to the type of change. |
desruisseaux
added
dependencies
|
On jenkins we have Maven 4-rc-3 .... We should ask infra for update .... or disable jenkis build ... |
|
This PR seems to have broken the CI, and should not have been merged yet. |
At the time that this pull request was submitted, the GitHub checks were successful. The failure that we observe in #503 came later. Strangely, Jenkins also fails to build the master branch of maven-clean-plugin and maven-compiler-plugins for the same reason, but those failures do not appear in GitHub actions (contrarily to this maven-jar-plugin). |
|
no way - merging PR if build is failing? |
|
Jenkins is used only for branches from repo ... for PR from forks is not used ... so PR can pass without jenkins build |
|
So can we turn on Jenkins for PRs from forks too? If not, maybe we can just move everything to GitHub actions and disable Jenkins completely? Whether you use a fork or a branch, shouldn't change which checks are run. |
The build was not failing when this PR was merged, at least not on GitHub actions. It was failing on Jenkins, but I was not aware of that. Looking at the Jenkins page, Jenkins builds were failing for the master branches of many projects for more than 4 months, and I don't know if anyone paid attention. |
6 participants
This pull request combines 3 tasks in 3 separated commits:
useDefaultManifestFileconfiguration parameter, which was deprecated since Maven 3.0.0.The changes in this pull request should not cause significant change in the plugin behaviour, except for the removal of the
useDefaultManifestFileoption and when a null argument is given to theAbstractJarMojo.getJarFile(Path, String, String)method. In the latter case, theIllegalArgumentExceptionhas been replaced byNullPointerException.