diff --git a/maven-plugin-plugin/pom.xml b/maven-plugin-plugin/pom.xml index 381ab7dd4..2b9eaf353 100644 --- a/maven-plugin-plugin/pom.xml +++ b/maven-plugin-plugin/pom.xml @@ -57,6 +57,10 @@ org.apache.maven.plugin-tools maven-plugin-tools-generators + + org.ow2.asm + asm + @@ -83,7 +87,6 @@ org.apache.maven maven-model - provided org.apache.maven @@ -104,13 +107,10 @@ org.apache.maven.resolver maven-resolver-api - ${resolverVersion} - provided org.apache.maven.resolver maven-resolver-util - ${resolverVersion} javax.inject @@ -144,17 +144,14 @@ org.junit.jupiter - junit-jupiter + junit-jupiter-api test - org.hamcrest - hamcrest + org.junit.jupiter + junit-jupiter-params test - - - diff --git a/maven-plugin-plugin/src/test/java/org/apache/maven/plugin/plugin/DescriptorGeneratorMojoTest.java b/maven-plugin-plugin/src/test/java/org/apache/maven/plugin/plugin/DescriptorGeneratorMojoTest.java index 4956340ea..77f2933c4 100644 --- a/maven-plugin-plugin/src/test/java/org/apache/maven/plugin/plugin/DescriptorGeneratorMojoTest.java +++ b/maven-plugin-plugin/src/test/java/org/apache/maven/plugin/plugin/DescriptorGeneratorMojoTest.java @@ -25,8 +25,7 @@ import org.junit.jupiter.params.provider.Arguments; import org.junit.jupiter.params.provider.MethodSource; -import static org.hamcrest.CoreMatchers.is; -import static org.hamcrest.MatcherAssert.assertThat; +import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.params.provider.Arguments.arguments; // at least one test class must be public for test-javadoc report @@ -42,7 +41,7 @@ public static Stream goalPrefixes() { @ParameterizedTest @MethodSource("goalPrefixes") void defaultGoalPrefix(String groupId, String artifactId, String expectedGoal) { - assertThat(DescriptorGeneratorMojo.getDefaultGoalPrefix(newProject(groupId, artifactId)), is(expectedGoal)); + assertEquals(expectedGoal, DescriptorGeneratorMojo.getDefaultGoalPrefix(newProject(groupId, artifactId))); } private MavenProject newProject(final String groupId, final String artifactId) { diff --git a/maven-plugin-report-plugin/pom.xml b/maven-plugin-report-plugin/pom.xml index 0ec82d5a3..9ec4fa597 100644 --- a/maven-plugin-report-plugin/pom.xml +++ b/maven-plugin-report-plugin/pom.xml @@ -47,12 +47,10 @@ org.apache.maven maven-core - provided org.apache.maven maven-plugin-api - provided org.apache.maven.reporting @@ -61,28 +59,18 @@ org.apache.maven maven-model-builder - provided org.apache.maven maven-model - provided org.apache.maven maven-artifact - provided - - - org.apache.maven - maven-settings - provided org.apache.maven.resolver maven-resolver-api - ${resolverVersion} - provided @@ -94,10 +82,6 @@ org.apache.maven.plugin-tools maven-plugin-tools-api - - org.apache.maven.plugin-tools - maven-plugin-tools-generators - @@ -132,6 +116,11 @@ plexus-i18n 1.0.0 + + org.eclipse.sisu + org.eclipse.sisu.plexus + provided + @@ -139,11 +128,6 @@ junit-jupiter-api test - - org.junit.jupiter - junit-jupiter - test - org.apache.maven.plugins diff --git a/maven-plugin-report-plugin/src/main/java/org/apache/maven/plugins/plugin/descriptor/EnhancedPluginDescriptorBuilder.java b/maven-plugin-report-plugin/src/main/java/org/apache/maven/plugins/plugin/descriptor/EnhancedPluginDescriptorBuilder.java index 7c15b1b69..fbbe2a192 100644 --- a/maven-plugin-report-plugin/src/main/java/org/apache/maven/plugins/plugin/descriptor/EnhancedPluginDescriptorBuilder.java +++ b/maven-plugin-report-plugin/src/main/java/org/apache/maven/plugins/plugin/descriptor/EnhancedPluginDescriptorBuilder.java @@ -34,13 +34,12 @@ import org.apache.maven.rtinfo.RuntimeInformation; import org.apache.maven.tools.plugin.EnhancedParameterWrapper; import org.apache.maven.tools.plugin.ExtendedPluginDescriptor; -import org.apache.maven.tools.plugin.generator.PluginDescriptorFilesGenerator; import org.codehaus.plexus.configuration.PlexusConfiguration; import org.codehaus.plexus.configuration.PlexusConfigurationException; /** * Reads enhanced plugin.xml files as generated by - * {@link PluginDescriptorFilesGenerator} and used by {@link PluginReport}. + * {@code PluginDescriptorFilesGenerator} and used by {@link PluginReport}. * Populates the slightly extended {@link Parameter} object {@link EnhancedParameterWrapper}. * In addition, populates all (optional) elements added after Maven Plugin API 3.2.5. */ diff --git a/maven-plugin-tools-annotations/pom.xml b/maven-plugin-tools-annotations/pom.xml index feb6a0223..e159c4d40 100644 --- a/maven-plugin-tools-annotations/pom.xml +++ b/maven-plugin-tools-annotations/pom.xml @@ -36,6 +36,10 @@ org.apache.maven maven-plugin-api + + org.apache.maven + maven-core + org.apache.maven maven-model @@ -59,7 +63,6 @@ org.apache.maven.resolver maven-resolver-api - ${resolverVersion} org.slf4j @@ -69,11 +72,6 @@ org.codehaus.plexus plexus-utils - - org.eclipse.sisu - org.eclipse.sisu.plexus - compile - org.codehaus.plexus plexus-archiver @@ -102,24 +100,11 @@ com.thoughtworks.qdox qdox - - org.mockito - mockito-core - test - - - org.junit.jupiter - junit-jupiter-engine - test - + + org.junit.jupiter - junit-jupiter-params - test - - - org.codehaus.plexus - plexus-testing + junit-jupiter-api test @@ -138,6 +123,12 @@ slf4j-simple test + + + org.codehaus.plexus + plexus-xml + test + diff --git a/maven-plugin-tools-annotations/src/test/java/org/apache/maven/tools/plugin/extractor/annotations/scanner/DefaultMojoAnnotationsScannerTest.java b/maven-plugin-tools-annotations/src/test/java/org/apache/maven/tools/plugin/extractor/annotations/scanner/DefaultMojoAnnotationsScannerTest.java index a21c0736a..4bfcfadce 100644 --- a/maven-plugin-tools-annotations/src/test/java/org/apache/maven/tools/plugin/extractor/annotations/scanner/DefaultMojoAnnotationsScannerTest.java +++ b/maven-plugin-tools-annotations/src/test/java/org/apache/maven/tools/plugin/extractor/annotations/scanner/DefaultMojoAnnotationsScannerTest.java @@ -40,7 +40,6 @@ import org.junit.jupiter.api.Test; import static org.assertj.core.api.Assertions.assertThat; -import static org.codehaus.plexus.testing.PlexusExtension.getBasedir; import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertFalse; import static org.junit.jupiter.api.Assertions.assertNotNull; @@ -138,7 +137,7 @@ void scanParametersWithGenerics() throws ExtractionException, IOException { @Test void scanFooMojoClass() throws Exception { MojoAnnotationsScannerRequest request = new MojoAnnotationsScannerRequest(); - request.setClassesDirectories(Collections.singletonList(new File(getBasedir(), "target/test-classes"))); + request.setClassesDirectories(Collections.singletonList(new File("target/test-classes"))); request.setIncludePatterns(Arrays.asList("**/FooMojo.class")); request.setProject(new MavenProject()); diff --git a/maven-plugin-tools-api/pom.xml b/maven-plugin-tools-api/pom.xml index 699867ad0..48d67504e 100644 --- a/maven-plugin-tools-api/pom.xml +++ b/maven-plugin-tools-api/pom.xml @@ -70,26 +70,18 @@ org.apache.maven.resolver maven-resolver-api - ${resolverVersion} org.codehaus.plexus plexus-classworlds 2.9.0 - - - org.eclipse.sisu - org.eclipse.sisu.plexus + provided org.codehaus.plexus plexus-utils - - org.codehaus.plexus - plexus-xml - org.apache.httpcomponents @@ -116,7 +108,7 @@ org.junit.jupiter - junit-jupiter-engine + junit-jupiter-api test diff --git a/maven-plugin-tools-api/src/test/java/org/apache/maven/tools/plugin/javadoc/JavadocSiteTest.java b/maven-plugin-tools-api/src/test/java/org/apache/maven/tools/plugin/javadoc/JavadocSiteTest.java index 05303b84f..4355fb82f 100644 --- a/maven-plugin-tools-api/src/test/java/org/apache/maven/tools/plugin/javadoc/JavadocSiteTest.java +++ b/maven-plugin-tools-api/src/test/java/org/apache/maven/tools/plugin/javadoc/JavadocSiteTest.java @@ -32,10 +32,10 @@ import org.junit.jupiter.params.ParameterizedTest; import org.junit.jupiter.params.provider.Arguments; import org.junit.jupiter.params.provider.MethodSource; -import org.opentest4j.AssertionFailedError; import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertThrows; +import static org.junit.jupiter.api.Assertions.fail; /** * Tests against the locally available javadoc sites. Doesn't require internet connectivity. @@ -150,12 +150,12 @@ static void assertUrlValid(final URI url) { if (url.getFragment() != null) { Pattern pattern = JavadocSite.getAnchorPattern(url.getFragment()); if (!reader.lines().anyMatch(pattern.asPredicate())) { - throw new AssertionFailedError("Although URL " + url + " exists, no line matching the pattern " - + pattern + " found in response"); + fail("Although URL " + url + " exists, no line matching the pattern " + pattern + + " found in response"); } } } catch (IOException e) { - throw new AssertionFailedError("Could not find URL " + url, e); + fail("Could not find URL " + url, e); } } } diff --git a/maven-plugin-tools-api/src/test/java/org/apache/maven/tools/plugin/util/stubs/MavenReportStub.java b/maven-plugin-tools-api/src/test/java/org/apache/maven/tools/plugin/util/stubs/MavenReportStub.java index 0358de025..ae7e78174 100644 --- a/maven-plugin-tools-api/src/test/java/org/apache/maven/tools/plugin/util/stubs/MavenReportStub.java +++ b/maven-plugin-tools-api/src/test/java/org/apache/maven/tools/plugin/util/stubs/MavenReportStub.java @@ -20,8 +20,6 @@ import java.util.Locale; -import org.apache.maven.doxia.siterenderer.Renderer; -import org.apache.maven.project.MavenProject; import org.apache.maven.reporting.AbstractMavenReport; import org.apache.maven.reporting.MavenReportException; @@ -33,24 +31,6 @@ public class MavenReportStub extends AbstractMavenReport { @Override protected void executeReport(Locale locale) throws MavenReportException {} - /** {@inheritDoc} */ - @Override - protected String getOutputDirectory() { - return null; - } - - /** {@inheritDoc} */ - @Override - protected MavenProject getProject() { - return null; - } - - /** {@inheritDoc} */ - @Override - protected Renderer getSiteRenderer() { - return null; - } - /** {@inheritDoc} */ @Override public String getDescription(Locale locale) { diff --git a/maven-plugin-tools-generators/pom.xml b/maven-plugin-tools-generators/pom.xml index e60d81f9a..f5c14b011 100644 --- a/maven-plugin-tools-generators/pom.xml +++ b/maven-plugin-tools-generators/pom.xml @@ -78,6 +78,7 @@ org.eclipse.sisu org.eclipse.sisu.plexus + provided @@ -88,16 +89,6 @@ org.slf4j slf4j-api - ${slf4jVersion} - - - - org.ow2.asm - asm - - - org.ow2.asm - asm-commons @@ -116,17 +107,7 @@ org.junit.jupiter - junit-jupiter-engine - test - - - org.apache.maven.resolver - maven-resolver-impl - ${resolverVersion} - - - org.codehaus.plexus - plexus-testing + junit-jupiter-api test diff --git a/maven-plugin-tools-generators/src/test/java/org/apache/maven/tools/plugin/generator/PluginDescriptorFilesGeneratorTest.java b/maven-plugin-tools-generators/src/test/java/org/apache/maven/tools/plugin/generator/PluginDescriptorFilesGeneratorTest.java index 98fd2e41e..8ad37cd1b 100644 --- a/maven-plugin-tools-generators/src/test/java/org/apache/maven/tools/plugin/generator/PluginDescriptorFilesGeneratorTest.java +++ b/maven-plugin-tools-generators/src/test/java/org/apache/maven/tools/plugin/generator/PluginDescriptorFilesGeneratorTest.java @@ -36,7 +36,6 @@ import org.apache.maven.tools.plugin.javadoc.JavadocLinkGenerator; import org.codehaus.plexus.component.repository.ComponentDependency; import org.codehaus.plexus.configuration.PlexusConfiguration; -import org.codehaus.plexus.testing.PlexusTest; import org.codehaus.plexus.util.ReaderFactory; import org.junit.jupiter.api.Test; @@ -47,7 +46,6 @@ /** * @author Jason van Zyl */ -@PlexusTest public class PluginDescriptorFilesGeneratorTest extends AbstractGeneratorTestCase { @Override protected void extendPluginDescriptor(PluginDescriptor pluginDescriptor) throws DuplicateParameterException { diff --git a/pom.xml b/pom.xml index 864f45d9a..07b849b0c 100644 --- a/pom.xml +++ b/pom.xml @@ -123,11 +123,6 @@ maven-plugin-tools-generators ${project.version} - - org.apache.maven.plugin-tools - maven-plugin-tools-model - ${project.version} - org.apache.maven.plugin-tools maven-plugin-tools-annotations @@ -147,32 +142,50 @@ org.apache.maven maven-model-builder ${maven3Version} + provided org.apache.maven maven-model ${maven3Version} + provided org.apache.maven maven-plugin-api ${maven3Version} + provided org.apache.maven maven-core ${maven3Version} + provided org.apache.maven maven-artifact ${maven3Version} + provided org.apache.maven maven-settings ${maven3Version} + provided + + + org.apache.maven.resolver + maven-resolver-api + ${resolverVersion} + provided + + org.apache.maven.resolver + maven-resolver-util + ${resolverVersion} + + org.apache.maven.reporting @@ -189,6 +202,7 @@ org.slf4j slf4j-api ${slf4jVersion} + provided org.slf4j @@ -240,11 +254,6 @@ asm ${asmVersion} - - org.ow2.asm - asm-commons - ${asmVersion} - org.ow2.asm asm-util @@ -263,24 +272,6 @@ 3.27.6 test - - org.hamcrest - hamcrest - 3.0 - test - - - org.mockito - mockito-core - 3.12.4 - test - - - org.codehaus.plexus - plexus-testing - 1.6.1 - test -