diff --git a/maven-resolver-transport-minio/pom.xml b/maven-resolver-transport-minio/pom.xml index 5755def51..3e795db5b 100644 --- a/maven-resolver-transport-minio/pom.xml +++ b/maven-resolver-transport-minio/pom.xml @@ -34,8 +34,22 @@ 8 + + 5.1.0 + + + + com.squareup.okhttp3 + okhttp-bom + ${okhttpVersion} + pom + import + + + + org.slf4j @@ -63,10 +77,15 @@ io.minio minio - 8.5.17 + 8.6.0 + + com.squareup.okhttp3 + okhttp-jvm + ${okhttpVersion} + commons-codec commons-codec diff --git a/maven-resolver-transport-minio/src/test/java/org/eclipse/aether/transport/minio/MinioTransporterIT.java b/maven-resolver-transport-minio/src/test/java/org/eclipse/aether/transport/minio/MinioTransporterIT.java index 6332633ff..1547bd639 100644 --- a/maven-resolver-transport-minio/src/test/java/org/eclipse/aether/transport/minio/MinioTransporterIT.java +++ b/maven-resolver-transport-minio/src/test/java/org/eclipse/aether/transport/minio/MinioTransporterIT.java @@ -59,7 +59,6 @@ class MinioTransporterIT { private static final String OBJECT_CONTENT = "content"; private MinIOContainer minioContainer; - private MinioClient minioClient; private RepositorySystemSession session; private ObjectNameMapperFactory objectNameMapperFactory; @@ -69,19 +68,19 @@ void startSuite() throws Exception { minioContainer = new MinIOContainer("minio/minio:latest"); minioContainer.start(); - minioClient = MinioClient.builder() + try (MinioClient minioClient = MinioClient.builder() .endpoint(minioContainer.getS3URL()) .credentials(minioContainer.getUserName(), minioContainer.getPassword()) - .build(); - - minioClient.makeBucket(MakeBucketArgs.builder().bucket(BUCKET_NAME).build()); - try (FileUtils.TempFile tempFile = FileUtils.newTempFile()) { - Files.write(tempFile.getPath(), OBJECT_CONTENT.getBytes(StandardCharsets.UTF_8)); - minioClient.uploadObject(UploadObjectArgs.builder() - .bucket(BUCKET_NAME) - .object(OBJECT_NAME) - .filename(tempFile.getPath().toString()) - .build()); + .build()) { + minioClient.makeBucket(MakeBucketArgs.builder().bucket(BUCKET_NAME).build()); + try (FileUtils.TempFile tempFile = FileUtils.newTempFile()) { + Files.write(tempFile.getPath(), OBJECT_CONTENT.getBytes(StandardCharsets.UTF_8)); + minioClient.uploadObject(UploadObjectArgs.builder() + .bucket(BUCKET_NAME) + .object(OBJECT_NAME) + .filename(tempFile.getPath().toString()) + .build()); + } } session = new DefaultRepositorySystemSession(h -> true); @@ -135,7 +134,7 @@ void peekWithWrongAuth() throws NoTransporterException { fail("Should throw"); } catch (Exception e) { assertInstanceOf(ErrorResponseException.class, e); - assertEquals(transporter.classify(e), Transporter.ERROR_OTHER); + assertEquals(Transporter.ERROR_OTHER, transporter.classify(e)); } } } @@ -149,7 +148,7 @@ void peekNonexistent() throws NoTransporterException { fail("Should throw"); } catch (Exception e) { assertInstanceOf(ErrorResponseException.class, e); - assertEquals(transporter.classify(e), Transporter.ERROR_NOT_FOUND); + assertEquals(Transporter.ERROR_NOT_FOUND, transporter.classify(e)); } } } @@ -172,7 +171,7 @@ void getNonexistent() throws NoTransporterException { fail("Should throw"); } catch (Exception e) { assertInstanceOf(ErrorResponseException.class, e); - assertEquals(transporter.classify(e), Transporter.ERROR_NOT_FOUND); + assertEquals(Transporter.ERROR_NOT_FOUND, transporter.classify(e)); } } }