Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MSHADE-420] create IT: 2 runs with different TZ give different jars #179

Merged
merged 2 commits into from
Jan 31, 2024
Merged

[MSHADE-420] create IT: 2 runs with different TZ give different jars #179

merged 2 commits into from
Jan 31, 2024

Conversation

hboutemy
Copy link
Member

@hboutemy hboutemy commented Mar 4, 2023

@elharo elharo requested a review from slawekjaranowski March 21, 2023 11:34
@hboutemy hboutemy force-pushed the MSHADE-420 branch 2 times, most recently from b8d3c30 to c789e81 Compare January 21, 2024 15:42
@hboutemy
Copy link
Member Author

@michael-o @slawekjaranowski based on latest enhancement in the IT, it seems there is an inconsistency in ZipEntry:

  • if it's basic xdos time, the time is calculated against current TZ
  • but if it's mtime from extra fields, the time is not calculated against TZ
    given setTime always expects a time against current TZ, this is what gives the current difference

the problem is that i don't see how to workaround...
any idea?

@hboutemy
Copy link
Member Author

finally, I found a workaround in 079560e (that still needs to be enhanced, but at least, it proves the concept)
review appreciated

@hboutemy hboutemy mentioned this pull request Jan 21, 2024
Closed
michael-o
michael-o requested changes Jan 22, 2024
View reviewed changes
src/it/projects/MSHADE-420/invoker.properties Outdated Show resolved Hide resolved
src/it/projects/MSHADE-420/verify.groovy Outdated Show resolved Hide resolved
src/it/projects/MSHADE-420/verify.groovy Outdated Show resolved Hide resolved
src/it/projects/MSHADE-420/verify.groovy Outdated Show resolved Hide resolved
src/it/projects/MSHADE-420/zipdetails.txt Outdated Show resolved Hide resolved
@hboutemy hboutemy requested a review from michael-o January 23, 2024 05:50
@hboutemy hboutemy force-pushed the MSHADE-420 branch 2 times, most recently from eee3cb0 to 9e53c7e Compare January 30, 2024 07:08
@hboutemy hboutemy merged commit bd982e7 into master Jan 31, 2024
49 checks passed
@hboutemy hboutemy deleted the MSHADE-420 branch January 31, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slawekjaranowski slawekjaranowski Awaiting requested review from slawekjaranowski

@michael-o michael-o Awaiting requested review from michael-o

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hboutemy @michael-o @slawekjaranowski