-
Notifications
You must be signed in to change notification settings - Fork 291
Maven 3.9.12 - release notes #1473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Reviewed as of now, ping me, when the open TODOs were filled / the release is done (I've read your mail about 3.9.12 plans). |
0b29cc0 to
3383181
Compare
| under the License. | ||
| --> | ||
|
|
||
| # Release Notes – Maven 3.9.12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think – is wrong. This should be an em dash if it's a dash at all, though I suspect maybe a dash shouldn't be used here. DuckDuckGo LLM says"Use an em dash (—) to set off extra information or indicate a break in a sentence, while an en dash (–) is typically used to represent ranges, such as dates or numbers. The em dash is longer and can replace commas or parentheses, whereas the en dash is shorter and often signifies "to" in ranges."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It depends on the style, APA, Chicago, etc. There is no caonical reference. Don't change a single file without changing the rest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requiring things to change everywhere is common meta mistake, and I specifically disagree. It is better to do the wrong thing 19 times and the right thing once than doing the wrong thing 20 times. Nor is it required or even a good idea to fix the other 19 mistakes to avoid introducing the 20th here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @elharo here. Let's start using the correct dashes from now an, does not hurt if old release notes are different.
|
|
||
| Maven 3.9.12 is [available for download][0]. | ||
|
|
||
| Maven is a software project management and comprehension tool. Based on the concept of a project object model (POM), Maven can manage a project's build, reporting, and documentation from a central place. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove this. I know we say it everywhere, but it's really techno-gibberish.
| under the License. | ||
| --> | ||
|
|
||
| # Release Notes – Maven 3.9.12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requiring things to change everywhere is common meta mistake, and I specifically disagree. It is better to do the wrong thing 19 times and the right thing once than doing the wrong thing 20 times. Nor is it required or even a good idea to fix the other 19 mistakes to avoid introducing the 20th here.
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
mvn siteand examine output intarget/sitedirectory.Site will also be built on your pull request automatically and attached to GitHub Action result.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.