Skip to content

Conversation

@gnodet
Copy link
Contributor

@gnodet gnodet commented Dec 9, 2021

@michael-o This is a small refactoring, the goal is mainly to make mvnd main class not to rewrite the whole MavenCli.
The consequence for mvnd is in the following commit apache/maven-mvnd@6d2fb40.

@cstamas
Copy link
Member

cstamas commented Dec 9, 2021

Nice!

public static final String EXTENSIONS_FILENAME = ".mvn/extensions.xml";

private static final String MVN_MAVEN_CONFIG = ".mvn/maven.config";
public static final String MVN_MAVEN_CONFIG = ".mvn/maven.config";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this property will likely go away with #602

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading #602, I'm not sure I agree with adding more intelligence in the launch scripts and removing it from the java code. This will make tools embedding maven much more difficult to behave consistently with maven.

@AlexanderAshitkin
Copy link

AlexanderAshitkin commented Dec 11, 2021

Allowing to ovveride dozens of methods makes MavenCli contract vague and could complicate miantenance. going forward It will be easier to maintain MavenCli with public api/interface extracted. For clients it will be easier as well to implement custom logic by delegation. So far it is unclear how to use and extend this class correctly and safely

@gnodet
Copy link
Contributor Author

gnodet commented Dec 13, 2021

Allowing to ovveride dozens of methods makes MavenCli contract vague and could complicate miantenance. going forward It will be easier to maintain MavenCli with public api/interface extracted. For clients it will be easier as well to implement custom logic by delegation. So far it is unclear how to use and extend this class correctly and safely

The main usage is apache/maven-mvnd@6d2fb40

@gnodet gnodet closed this Oct 11, 2022
@cstamas
Copy link
Member

cstamas commented May 23, 2024

This PR needs to be revived, at least on master (mvn4) as maintenance of mvnd is nightmare. Maven 3.9.x (mvnd m39) can remain as is, as it is not getting new features anymore, and hence, the frequency of changes will tend to zero, but mvn4 is different story.

@jira-importer
Copy link

Resolve #8085

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants