Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-14284 ConsumeKinesisStream migrate property names to new convention #9741

Merged
merged 4 commits into from
Feb 25, 2025

Conversation

dariuszseweryn
Copy link
Contributor

Summary

NIFI-14284

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-14284
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-14284

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • (no new) New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • (no new) New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • (no changes) Documentation formatting appears as expected in rendered files

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing this modernization for property names @dariuszseweryn. The changes look good, but the displayName() call can also be removed.

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the adjustments @dariuszseweryn, the latest version looks good! +1 merging

@exceptionfactory exceptionfactory merged commit 71d244d into apache:main Feb 25, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants