Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract oio::HttpClient as a trait #4471

Closed
Xuanwo opened this issue Apr 12, 2024 · 1 comment · Fixed by #5184
Closed

Extract oio::HttpClient as a trait #4471

Xuanwo opened this issue Apr 12, 2024 · 1 comment · Fixed by #5184

Comments

@Xuanwo
Copy link
Member

Xuanwo commented Apr 12, 2024

OpenDAL now depends on reqwest by default. However, some users wish to customize their HTTP client by implementing their own solutions or adding middleware. Perhaps we could define oio::HttpClient as a trait, allowing users to integrate their preferred client instead of being limited to reqwest.

Closing #4286
@Xuanwo
Copy link
Member Author

Xuanwo commented Apr 12, 2024

cc @wenym1, I will track the design/implementation progress here.

@everpcpc everpcpc mentioned this issue Oct 15, 2024
Merged
@Xuanwo Xuanwo mentioned this issue Oct 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(core): abstract HttpFetch trait for raw http client everpcpc/opendal
1 participant
@Xuanwo