From 0df4b40c6832029c110230955f1b38a9fe340cd4 Mon Sep 17 00:00:00 2001 From: suyanhanx Date: Tue, 23 May 2023 18:12:11 +0800 Subject: [PATCH] fix(core): appender complete check Signed-off-by: suyanhanx --- core/src/layers/complete.rs | 2 +- core/src/services/oss/backend.rs | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/core/src/layers/complete.rs b/core/src/layers/complete.rs index e4488c6f177..0fe80f9bb50 100644 --- a/core/src/layers/complete.rs +++ b/core/src/layers/complete.rs @@ -670,7 +670,7 @@ impl CompleteAppender { #[cfg(debug_assertions)] impl Drop for CompleteAppender { fn drop(&mut self) { - if self.inner.is_none() { + if self.inner.is_some() { // Do we need to panic here? log::warn!("appender has not been closed, must be a bug") } diff --git a/core/src/services/oss/backend.rs b/core/src/services/oss/backend.rs index c436fc98314..64e78151391 100644 --- a/core/src/services/oss/backend.rs +++ b/core/src/services/oss/backend.rs @@ -49,6 +49,7 @@ const DEFAULT_WRITE_MIN_SIZE: usize = 8 * 1024 * 1024; /// - [x] stat /// - [x] read /// - [x] write +/// - [x] append /// - [x] create_dir /// - [x] delete /// - [x] copy