Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add codspeed for benchmark #5280

Merged
merged 16 commits into from
Nov 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 73 additions & 0 deletions .github/workflows/test_benchmark.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.

name: Benchmark Test

on:
push:
branches:
- main
pull_request:
branches:
- main
paths:
- "core/src/**"
- "core/benches/**"
- "!core/src/docs/**"
- ".github/workflows/test_benchmark.yml"
# `workflow_dispatch` is needed by codspeed for first time trigger
workflow_dispatch:

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
cancel-in-progress: true

jobs:
benchmark:
dqhl76 marked this conversation as resolved.
Show resolved Hide resolved
runs-on: ubuntu-latest
if: github.event_name == 'push' || !github.event.pull_request.head.repo.fork
steps:
- uses: actions/checkout@v4
- name: Setup Rust toolchain
uses: ./.github/actions/setup
- uses: 1password/load-secrets-action/configure@v1
with:
connect-host: ${{ secrets.OP_CONNECT_HOST }}
connect-token: ${{ secrets.OP_CONNECT_TOKEN }}
- uses: 1password/load-secrets-action@v1
with:
export-env: true
env:
CODSPEED_TOKEN: op://services/codspeed/token
- name: Setup codspeed
run: cargo install cargo-codspeed
- name: Setup Memory env
uses: ./.github/services/memory/memory
- name: Install codpseed-criterion-compat
working-directory: core
run: cargo add --dev --rename criterion --features async,async_tokio codspeed-criterion-compat@2.7.2
- name: Build the benchmark targets
working-directory: core
run: cargo codspeed build --features tests,services-memory
- name: Run the benchmarks
uses: CodSpeedHQ/action@v3
env:
OPENDAL_TEST: memory
with:
dqhl76 marked this conversation as resolved.
Show resolved Hide resolved
working-directory: core
run: cargo codspeed run
token: ${{ env.CODSPEED_TOKEN }}
46 changes: 25 additions & 21 deletions core/benches/types/concurrent_tasks.rs
Original file line number Diff line number Diff line change
Expand Up @@ -30,30 +30,34 @@ pub fn bench_concurrent_tasks(c: &mut Criterion) {
let mut group = c.benchmark_group("bench_concurrent_tasks");

for concurrent in [1, 2, 4, 8, 16] {
group.bench_with_input(concurrent.to_string(), &concurrent, |b, concurrent| {
b.to_async(&*TOKIO).iter_batched(
|| {
ConcurrentTasks::new(Executor::new(), *concurrent, |()| {
Box::pin(async {
tokio::time::sleep(Duration::from_millis(1)).await;
((), Ok(()))
group.bench_with_input(
format!("concurrent {}", concurrent),
&concurrent,
|b, concurrent| {
b.to_async(&*TOKIO).iter_batched(
|| {
ConcurrentTasks::new(Executor::new(), *concurrent, |()| {
Box::pin(async {
tokio::time::sleep(Duration::from_millis(1)).await;
((), Ok(()))
})
})
})
},
|mut tasks| async move {
for _ in 0..100 {
let _ = tasks.execute(()).await;
}
},
|mut tasks| async move {
for _ in 0..100 {
let _ = tasks.execute(()).await;
}

loop {
if tasks.next().await.is_none() {
break;
loop {
if tasks.next().await.is_none() {
break;
}
}
}
},
BatchSize::PerIteration,
)
});
},
BatchSize::PerIteration,
)
},
);
}

group.finish()
Expand Down
Loading