Fixes to v2.5 and v2.6 to get things working again #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The actionloop goproxy executable fails to run in the ruby-2.6-alpine image, but works just fine in the debian based ruby-2.6 image. Since action-ruby-v2.5 is based on ruby-2.5 (and not ruby-2.5-alpine) it seems better to use the larger image anyways, so not worth debugging why the actionloop proxy isn't running on alpine.
dgrove-oss
changed the title
rabbah
approved these changes
Feb 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
version 2.1.0 of rack (released 26 days ago) breaks the ruby 2.5 action for openwhisk. Avoid the problem by pinning the version of rack to 2.0.x. See #44 for details.
The actionloop goproxy executable fails to run in the ruby-2.6-alpine image, but works just fine in the debian based ruby-2.6 image. Since action-ruby-v2.5 is based on ruby-2.5 (and not ruby-2.5-alpine) it is expedient to use the same larger-style image for both ruby versions and
get the tests working again