From 35f301f9b7e2d9bfd0dafdec7adc782d6cd8df54 Mon Sep 17 00:00:00 2001 From: daniilchik Date: Mon, 23 Sep 2024 15:42:43 +0300 Subject: [PATCH 01/50] docs: fixed javadocs warnings --- .../hadoop/hdds/scm/storage/BlockDataStreamOutput.java | 1 - .../ozone/client/io/BlockInputStreamFactory.java | 1 - .../ozone/client/io/BlockInputStreamFactoryImpl.java | 1 - .../ozone/client/io/ECBlockInputStreamFactory.java | 1 - .../ozone/client/io/ECBlockInputStreamFactoryImpl.java | 1 - .../io/ECBlockReconstructedStripeInputStream.java | 2 +- .../hadoop/hdds/annotation/InterfaceStability.java | 6 +++--- .../org/apache/hadoop/hdds/recon/ReconConfigKeys.java | 7 ++++--- .../java/org/apache/hadoop/hdds/scm/ScmConfig.java | 3 +-- .../org/apache/hadoop/hdds/scm/client/ScmClient.java | 2 +- .../scm/protocol/StorageContainerLocationProtocol.java | 2 +- .../main/java/org/apache/hadoop/ozone/OzoneConsts.java | 2 +- .../org/apache/hadoop/ozone/common/ChunkBuffer.java | 5 ++--- .../ozone/upgrade/LayoutVersionInstanceFactory.java | 8 +++----- .../ozone/container/common/impl/ContainerSet.java | 1 - .../common/states/endpoint/HeartbeatEndpointTask.java | 2 +- .../common/states/endpoint/RegisterEndpointTask.java | 2 +- .../ozone/container/common/volume/HddsVolume.java | 2 +- .../ozone/container/common/volume/VolumeInfo.java | 10 +++++----- .../ozone/container/common/volume/VolumeUsage.java | 2 +- .../keyvalue/helpers/KeyValueContainerUtil.java | 5 ++--- .../ozone/container/ozoneimpl/ContainerController.java | 1 - ...ontainerDatanodeProtocolClientSideTranslatorPB.java | 1 - ...ScmBlockLocationProtocolClientSideTranslatorPB.java | 2 +- .../apache/hadoop/hdds/server/http/ProfileServlet.java | 2 +- .../org/apache/hadoop/hdds/utils/HddsServerUtil.java | 2 +- .../java/org/apache/hadoop/hdds/utils/db/Table.java | 1 - .../org/apache/hadoop/ozone/audit/package-info.java | 2 +- .../apache/hadoop/hdds/scm/block/DeletedBlockLog.java | 2 +- .../org/apache/hadoop/hdds/scm/node/NodeManager.java | 1 - .../apache/hadoop/hdds/scm/node/NodeManagerMXBean.java | 2 +- 31 files changed, 34 insertions(+), 48 deletions(-) diff --git a/hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/BlockDataStreamOutput.java b/hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/BlockDataStreamOutput.java index d5423d4ec0b..48c77f2c863 100644 --- a/hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/BlockDataStreamOutput.java +++ b/hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/BlockDataStreamOutput.java @@ -364,7 +364,6 @@ public void writeOnRetry(long len) throws IOException { * it is a no op. * @param bufferFull flag indicating whether bufferFull condition is hit or * its called as part flush/close - * @return minimum commit index replicated to all nodes * @throws IOException IOException in case watch gets timed out */ public void watchForCommit(boolean bufferFull) throws IOException { diff --git a/hadoop-hdds/client/src/main/java/org/apache/hadoop/ozone/client/io/BlockInputStreamFactory.java b/hadoop-hdds/client/src/main/java/org/apache/hadoop/ozone/client/io/BlockInputStreamFactory.java index d347dee8512..8287a5a78bb 100644 --- a/hadoop-hdds/client/src/main/java/org/apache/hadoop/ozone/client/io/BlockInputStreamFactory.java +++ b/hadoop-hdds/client/src/main/java/org/apache/hadoop/ozone/client/io/BlockInputStreamFactory.java @@ -43,7 +43,6 @@ public interface BlockInputStreamFactory { * @param blockInfo The blockInfo representing the block. * @param pipeline The pipeline to be used for reading the block * @param token The block Access Token - * @param verifyChecksum Whether to verify checksums or not. * @param xceiverFactory Factory to create the xceiver in the client * @param refreshFunction Function to refresh the block location if needed * @return BlockExtendedInputStream of the correct type. diff --git a/hadoop-hdds/client/src/main/java/org/apache/hadoop/ozone/client/io/BlockInputStreamFactoryImpl.java b/hadoop-hdds/client/src/main/java/org/apache/hadoop/ozone/client/io/BlockInputStreamFactoryImpl.java index 8a87234a770..d9cadc948a6 100644 --- a/hadoop-hdds/client/src/main/java/org/apache/hadoop/ozone/client/io/BlockInputStreamFactoryImpl.java +++ b/hadoop-hdds/client/src/main/java/org/apache/hadoop/ozone/client/io/BlockInputStreamFactoryImpl.java @@ -71,7 +71,6 @@ public BlockInputStreamFactoryImpl(ByteBufferPool byteBufferPool, * @param blockInfo The blockInfo representing the block. * @param pipeline The pipeline to be used for reading the block * @param token The block Access Token - * @param verifyChecksum Whether to verify checksums or not. * @param xceiverFactory Factory to create the xceiver in the client * @param refreshFunction Function to refresh the pipeline if needed * @return BlockExtendedInputStream of the correct type. diff --git a/hadoop-hdds/client/src/main/java/org/apache/hadoop/ozone/client/io/ECBlockInputStreamFactory.java b/hadoop-hdds/client/src/main/java/org/apache/hadoop/ozone/client/io/ECBlockInputStreamFactory.java index 66e7a31337a..aca3cfed465 100644 --- a/hadoop-hdds/client/src/main/java/org/apache/hadoop/ozone/client/io/ECBlockInputStreamFactory.java +++ b/hadoop-hdds/client/src/main/java/org/apache/hadoop/ozone/client/io/ECBlockInputStreamFactory.java @@ -45,7 +45,6 @@ public interface ECBlockInputStreamFactory { * know are bad and should not be used. * @param repConfig The replication Config * @param blockInfo The blockInfo representing the block. - * @param verifyChecksum Whether to verify checksums or not. * @param xceiverFactory Factory to create the xceiver in the client * @param refreshFunction Function to refresh the block location if needed * @return BlockExtendedInputStream of the correct type. diff --git a/hadoop-hdds/client/src/main/java/org/apache/hadoop/ozone/client/io/ECBlockInputStreamFactoryImpl.java b/hadoop-hdds/client/src/main/java/org/apache/hadoop/ozone/client/io/ECBlockInputStreamFactoryImpl.java index 01d0b0a7b7e..41c46aad379 100644 --- a/hadoop-hdds/client/src/main/java/org/apache/hadoop/ozone/client/io/ECBlockInputStreamFactoryImpl.java +++ b/hadoop-hdds/client/src/main/java/org/apache/hadoop/ozone/client/io/ECBlockInputStreamFactoryImpl.java @@ -68,7 +68,6 @@ private ECBlockInputStreamFactoryImpl(BlockInputStreamFactory streamFactory, * know are bad and should not be used. * @param repConfig The replication Config * @param blockInfo The blockInfo representing the block. - * @param verifyChecksum Whether to verify checksums or not. * @param xceiverFactory Factory to create the xceiver in the client * @param refreshFunction Function to refresh the pipeline if needed * @return BlockExtendedInputStream of the correct type. diff --git a/hadoop-hdds/client/src/main/java/org/apache/hadoop/ozone/client/io/ECBlockReconstructedStripeInputStream.java b/hadoop-hdds/client/src/main/java/org/apache/hadoop/ozone/client/io/ECBlockReconstructedStripeInputStream.java index 31f94e0acad..229cc3f3e36 100644 --- a/hadoop-hdds/client/src/main/java/org/apache/hadoop/ozone/client/io/ECBlockReconstructedStripeInputStream.java +++ b/hadoop-hdds/client/src/main/java/org/apache/hadoop/ozone/client/io/ECBlockReconstructedStripeInputStream.java @@ -85,7 +85,7 @@ * Parity elements long. Missing or not needed elements should be set to null * in the array. The elements should be assigned to the array in EC index order. * - * Assuming we have n missing data locations, where n <= parity locations, the + * Assuming we have n missing data locations, where n {@literal <=} parity locations, the * ByteBuffers passed in from the client are either assigned to the decoder * input array, or they are assigned to the decoder output array, where * reconstructed data is written. The required number of parity buffers will be diff --git a/hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/annotation/InterfaceStability.java b/hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/annotation/InterfaceStability.java index 4251344139a..6e9ee946790 100644 --- a/hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/annotation/InterfaceStability.java +++ b/hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/annotation/InterfaceStability.java @@ -27,9 +27,9 @@ * class or method not changing over time. Currently the stability can be * {@link Stable}, {@link Evolving} or {@link Unstable}.
* - *