Remove duplicate scopes value in reference.conf #314
Conversation
mdedetrich
force-pushed
the
remove-duplicate-scopes-value-reference-conf
branch
from
d5d5849
to
9c691b2
Compare
mdedetrich
force-pushed
the
remove-duplicate-scopes-value-reference-conf
branch
from
9c691b2
to
2f82489
Compare
mdedetrich
requested review from
pjfanning,
He-Pin,
nvollmar,
seglo,
jxnu-liguobin and
gmethvin
|
Pinging @armanbilge since you originally wrote this, not sure if you wanted to throw in a quick 2c |
|
you'll need something like https://github.com/apache/incubator-pekko-connectors/pull/311/files#diff-5634c415cd8c8504fdb973a3ed092300b43c4b8fc1e184f7249eb29a55511f91R16 to get the mima check to work - v1.0.2-RC1 is current latest tag and this is only in staging repo - this PR looks like it could have a big mima footprint |
|
This PR doesn't have any MiMa impact, ill just rebase when 1.0.2 is released |
| @@ -37,7 +37,7 @@ private[auth] object GoogleOAuth2 { | |||
|
|
|||
| private val oAuthTokenUrl = "https://oauth2.googleapis.com/token" | |||
|
|
|||
| def getAccessToken(clientEmail: String, privateKey: String, scopes: Seq[String])( | |||
| def getAccessToken(clientEmail: String, privateKey: String, scopes: Set[String])( | |||
There was a problem hiding this comment.
I think a mina filter will be needed. or add an overloaded method which use seq.toSet then?
There was a problem hiding this comment.
I'll wait till 1.0.2 is out since that will fix the existing MiMa issue and then I will see.if this is still problematic
mdedetrich
force-pushed
the
remove-duplicate-scopes-value-reference-conf
branch
from
2f82489
to
fd460e2
Compare
|
Merging this since |
While working on #313 I realized that we have duplicate scope configuration settings, i.e. one here and another here.
This PR removes the scopes config here and instead makes the
ServiceAccountCredentialsuse the scopes value from here which is currently unused.We also change the collection from a
Seq/Listto aSetsince we want duplicates to be removed and ordering does not matter (also to make it consistent with #313)