Remove unused loggers / static fields (#121)

Author: findepi

polaris-core/src/main/java/io/polaris/core/catalog/PolarisCatalogHelpers.java

@@ -23,16 +23,12 @@
 import java.util.stream.Collectors;
 import org.apache.iceberg.catalog.Namespace;
 import org.apache.iceberg.catalog.TableIdentifier;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 
 /**
  * Holds helper methods translating between persistence-layer structs and Iceberg objects shared by
  * different Polaris components.
  */
 public class PolarisCatalogHelpers {
-  private static final Logger LOG = LoggerFactory.getLogger(PolarisCatalogHelpers.class);
-
   /** Not intended for instantiation. */
   private PolarisCatalogHelpers() {}
 

polaris-core/src/main/java/io/polaris/core/entity/CatalogEntity.java

@@ -41,17 +41,12 @@
 import org.apache.iceberg.exceptions.BadRequestException;
 import org.jetbrains.annotations.NotNull;
 import org.jetbrains.annotations.Nullable;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 
 /**
  * Catalog specific subclass of the {@link PolarisEntity} that handles conversion from the {@link
  * Catalog} model to the persistent entity model.
  */
 public class CatalogEntity extends PolarisEntity {
-  private static final Logger LOG = LoggerFactory.getLogger(CatalogEntity.class);
-
-  public static final long ROOT_CATALOG_ID = 0;
   public static final String CATALOG_TYPE_PROPERTY = "catalogType";
 
   // Specifies the object-store base location used for all Table file locations under the

polaris-core/src/main/java/io/polaris/core/persistence/PolarisEntityManager.java

@@ -31,17 +31,13 @@
 import java.util.function.Supplier;
 import org.jetbrains.annotations.NotNull;
 import org.jetbrains.annotations.Nullable;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 
 /**
  * Wraps logic of handling name-caching and entity-caching against a concrete underlying entity
  * store while exposing methods more natural for the Catalog layer to use. Encapsulates the various
  * id and name resolution mechanics around PolarisEntities.
  */
 public class PolarisEntityManager {
-  private static final Logger LOG = LoggerFactory.getLogger(PolarisEntityManager.class);
-
   private final PolarisMetaStoreManager metaStoreManager;
   private final Supplier<PolarisMetaStoreSession> sessionSupplier;
   private final EntityCache entityCache;

polaris-core/src/main/java/io/polaris/core/storage/gcp/GcpCredentialsStorageIntegration.java

@@ -30,7 +30,6 @@
 import java.io.IOException;
 import java.net.URI;
 import java.util.ArrayList;
-import java.util.Arrays;
 import java.util.EnumMap;
 import java.util.HashMap;
 import java.util.HashSet;
@@ -50,13 +49,10 @@
  */
 public class GcpCredentialsStorageIntegration
     extends InMemoryStorageIntegration<GcpStorageConfigurationInfo> {
-  public static final String TOKEN_URL = "https://sts.googleapis.com/v1/token";
   private final Logger LOGGER = LoggerFactory.getLogger(GcpCredentialsStorageIntegration.class);
 
   private final GoogleCredentials sourceCredentials;
   private final HttpTransportFactory transportFactory;
-  public static final Set<Integer> TOKEN_ENDPOINT_RETRYABLE_STATUS_CODES =
-      new HashSet<>(Arrays.asList(500, 503, 408, 429));
 
   public GcpCredentialsStorageIntegration(
       GoogleCredentials sourceCredentials, HttpTransportFactory transportFactory) {