address feedback

Author: gh-yzou

plugins/spark/v3.5/regtests/run.sh

@@ -88,7 +88,6 @@ for SCALA_VERSION in "${SCALA_VERSIONS[@]}"; do
   # run the spark_sql test
   loginfo "Starting test spark_sql.sh"
 
-  # export SPARK_HOME=/Users/yzou/spark-client-tests/spark-3.5.5-bin-hadoop3
   TEST_FILE="spark_sql.sh"
   TEST_SHORTNAME="spark_sql"
   TEST_TMPDIR="/tmp/polaris-spark-regtests/${TEST_SHORTNAME}_${SPARK_MAJOR_VERSION}_${SCALA_VERSION}"

plugins/spark/v3.5/regtests/setup.sh

@@ -153,4 +153,5 @@ echo "Launch spark-sql at ${SPARK_HOME}/bin/spark-sql"
 # this is mostly useful for building the Docker image with all needed dependencies
 ${SPARK_HOME}/bin/spark-sql -e "SELECT 1"
 
+# ensure SPARK_HOME is setup for later tests
 export SPARK_HOME=$SPARK_HOME

plugins/spark/v3.5/regtests/spark_sql.sh

@@ -21,7 +21,6 @@
 
 SPARK_BEARER_TOKEN="${REGTEST_ROOT_BEARER_TOKEN}"
 
-# echo "CURRENT SPARK HOME ${SPARK_HOME}"
 CATALOG_NAME="spark_sql_catalog"
 curl -i -X POST -H "Authorization: Bearer ${SPARK_BEARER_TOKEN}" -H 'Accept: application/json' -H 'Content-Type: application/json' \
   http://${POLARIS_HOST:-localhost}:8181/api/management/v1/catalogs \
@@ -75,6 +74,7 @@ drop namespace db1;
 drop namespace db2;
 EOF
 
+# clean up the spark_catalog dir
 rm -rf /tmp/spark_catalog/
 
 curl -i -X DELETE -H "Authorization: Bearer ${SPARK_BEARER_TOKEN}" -H 'Accept: application/json' -H 'Content-Type: application/json' \

plugins/spark/v3.5/spark/build.gradle.kts

@@ -19,9 +19,7 @@
 
 import com.github.jengelman.gradle.plugins.shadow.tasks.ShadowJar
 
-plugins {
-  id("polaris-client")
-}
+plugins { id("polaris-client") }
 
 // get version information
 val sparkMajorVersion = "3.5"