Skip to content

Python CI: pin mypy version to avoid CI failure due to new release #1903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eric-maynard merged 2 commits into from
Jun 16, 2025
Merged

Python CI: pin mypy version to avoid CI failure due to new release #1903

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25179b6
restrict mypy version
HonahX Jun 16, 2025
765c95e
update mypy version
HonahX Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/python/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ pytest-cov = ">= 2.8.1"
tox = ">= 3.9.0"
flake8 = ">= 4.0.0"
types-python-dateutil = ">= 2.8.19.14"
mypy = ">= 1.5"
mypy = ">= 1.5, <=1.16.1"
Copy link
Member

@XJDKC XJDKC Jun 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember this file is generated, should we modify this file considering this?

Copy link
Contributor

@eric-maynard eric-maynard Jun 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's now not supposed to be generated anymore

Copy link
Contributor Author

@HonahX HonahX Jun 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is no longer auto-generated because we also have CLI codes and test which needs additional dependencies/configs. We are currently manually managing the pyproject.toml

pyiceberg = "==0.9.1"
pre-commit = "==4.2.0"

Expand Down
Loading