From fa3a198b0652215f3063dc527d60ffe3a03d3cd0 Mon Sep 17 00:00:00 2001 From: Alexandre Dutra Date: Thu, 30 Oct 2025 13:49:32 +0100 Subject: [PATCH 1/3] Alternative, concise PR template This PR proposes an alternative PR template that is much shorter, and removes all the redundant claims. It also links to the contribution guidelines for further guidance. --- .github/pull_request_template.md | 76 +++++--------------------------- 1 file changed, 12 insertions(+), 64 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index fd6909a02c..0127504297 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,65 +1,13 @@ - -### What changes were proposed in this pull request? - - - -### Why are the changes needed? - - - -### Does this PR introduce _any_ user-facing change? - - - -### How was this patch tested? - - -### CHANGELOG.md - +๐Ÿ“ Describe what changes you're proposing, especially breaking or user-facing changes. +๐Ÿ“– See https://github.com/apache/polaris/blob/main/CONTRIBUTING.md for more. +--> + +## Checklist +- [ ] ๐Ÿ›ก๏ธ Don't disclose security issues! (contact security@apache.org) +- [ ] ๐Ÿ”— Related issue(s): Fixes # +- [ ] ๐Ÿงช Added/updated tests with good coverage +- [ ] ๐Ÿ’ก Added comments for complex logic +- [ ] โš™๏ธ Tested my changes with `./gradlew clean spotlessApply build` +- [ ] ๐Ÿงพ Updated `CHANGELOG.md` +- [ ] ๐Ÿ“š Updated documentation (in `site/content/in-dev/unreleased`) From 32e266f49fa542688847f52fbd884917d3d2a2cf Mon Sep 17 00:00:00 2001 From: Alexandre Dutra Date: Thu, 30 Oct 2025 16:29:50 +0100 Subject: [PATCH 2/3] review --- .github/pull_request_template.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 0127504297..1fb090aa2b 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -8,6 +8,6 @@ - [ ] ๐Ÿ”— Related issue(s): Fixes # - [ ] ๐Ÿงช Added/updated tests with good coverage - [ ] ๐Ÿ’ก Added comments for complex logic -- [ ] โš™๏ธ Tested my changes with `./gradlew clean spotlessApply build` -- [ ] ๐Ÿงพ Updated `CHANGELOG.md` -- [ ] ๐Ÿ“š Updated documentation (in `site/content/in-dev/unreleased`) +- [ ] โš™๏ธ Tested my changes with `./gradlew spotlessApply check` +- [ ] ๐Ÿงพ Updated `CHANGELOG.md` (if needed) +- [ ] ๐Ÿ“š Updated documentation in `site/content/in-dev/unreleased` (if needed) From 35a35cb240c99af9ecf4e6fe2fdbc97575f32c04 Mon Sep 17 00:00:00 2001 From: Alexandre Dutra Date: Mon, 3 Nov 2025 10:28:53 +0100 Subject: [PATCH 3/3] review --- .github/pull_request_template.md | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 1fb090aa2b..073652480b 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -5,9 +5,8 @@ ## Checklist - [ ] ๐Ÿ›ก๏ธ Don't disclose security issues! (contact security@apache.org) -- [ ] ๐Ÿ”— Related issue(s): Fixes # -- [ ] ๐Ÿงช Added/updated tests with good coverage +- [ ] ๐Ÿ”— Clearly explained why the changes are needed, or linked related issues: Fixes # +- [ ] ๐Ÿงช Added/updated tests with good coverage, or manually tested (and explained how) - [ ] ๐Ÿ’ก Added comments for complex logic -- [ ] โš™๏ธ Tested my changes with `./gradlew spotlessApply check` - [ ] ๐Ÿงพ Updated `CHANGELOG.md` (if needed) - [ ] ๐Ÿ“š Updated documentation in `site/content/in-dev/unreleased` (if needed)