Use CDI for more test setups #3040
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this avoids a bunch of redundant manual setup. the important parts are establishing a `RealmContext` by calling `QuarkusMock.installMockForType` and then populating `polarisContext` from the injected `CallContext`.
XN137
force-pushed
the
use-cdi-for-test-setups
branch
from
fe397ec to
8fd2400
Compare
snazy
approved these changes
Nov 13, 2025
Member
snazy
left a comment
snazy
left a comment
There was a problem hiding this comment.
LGTM!
It's a test-only change w/o any functional changes.
I'd suggest to remove unused fields/injections like AbstractPolicyCatalogTest.adminService and their dependencies in a follow-up.
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this avoids a bunch of redundant manual setup.
the important parts are establishing a
RealmContextby callingQuarkusMock.installMockForTypeand then populatingpolarisContextfrom the injected
CallContext.