-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: seek race #1265
Merged
Merged
fix: seek race #1265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodece
force-pushed
the
fix-seek-reconnect-race
branch
from
August 1, 2024 08:07
f8cfd6d
to
34a8743
Compare
RobertIndie
reviewed
Aug 1, 2024
nodece
force-pushed
the
fix-seek-reconnect-race
branch
4 times, most recently
from
August 10, 2024 18:20
4359d31
to
c7c4937
Compare
Could you review this PR again? @RobertIndie |
nodece
force-pushed
the
fix-seek-reconnect-race
branch
3 times, most recently
from
September 11, 2024 16:20
4dec08d
to
5ec03cb
Compare
nodece
force-pushed
the
fix-seek-reconnect-race
branch
5 times, most recently
from
October 12, 2024 09:24
6b57cc7
to
6920617
Compare
nodece
force-pushed
the
fix-seek-reconnect-race
branch
from
November 1, 2024 08:40
6920617
to
2fb2028
Compare
crossoverJie
reviewed
Nov 1, 2024
nodece
force-pushed
the
fix-seek-reconnect-race
branch
from
November 1, 2024 13:52
c0cc57a
to
079ec22
Compare
crossoverJie
reviewed
Nov 4, 2024
crossoverJie
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Broker's seek logic:
Seek issue:
Modifications