From 3ce53375c2f607c229ae463a5e086ed2dae757b5 Mon Sep 17 00:00:00 2001 From: catcherwong Date: Fri, 4 Aug 2023 01:01:59 +0000 Subject: [PATCH 1/2] csharp: Add using for HMACSHA1 Signed-off-by: catcherwong --- csharp/rocketmq-client-csharp/Signature.cs | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/csharp/rocketmq-client-csharp/Signature.cs b/csharp/rocketmq-client-csharp/Signature.cs index 0572a0628..750aae852 100644 --- a/csharp/rocketmq-client-csharp/Signature.cs +++ b/csharp/rocketmq-client-csharp/Signature.cs @@ -59,15 +59,17 @@ public static Dictionary Sign(Client client) var secretData = Encoding.ASCII.GetBytes(credentials.AccessSecret); var data = Encoding.ASCII.GetBytes(time); - var signer = new HMACSHA1(secretData); - var digest = signer.ComputeHash(data); - var hmac = BitConverter.ToString(digest).Replace("-", ""); - var authorization = $"{MetadataConstants.AlgorithmKey} " + - $"{MetadataConstants.CredentialKey}={credentials.AccessKey}, " + - $"{MetadataConstants.SignedHeadersKey}={MetadataConstants.DateTimeKey}, " + - $"{MetadataConstants.SignatureKey}={hmac}"; - dictionary.Add(MetadataConstants.Authorization, authorization); - return dictionary; + using (var signer = new HMACSHA1(secretData)) + { + var digest = signer.ComputeHash(data); + var hmac = BitConverter.ToString(digest).Replace("-", ""); + var authorization = $"{MetadataConstants.AlgorithmKey} " + + $"{MetadataConstants.CredentialKey}={credentials.AccessKey}, " + + $"{MetadataConstants.SignedHeadersKey}={MetadataConstants.DateTimeKey}, " + + $"{MetadataConstants.SignatureKey}={hmac}"; + dictionary.Add(MetadataConstants.Authorization, authorization); + return dictionary; + } } } } \ No newline at end of file From 2476dc53015808de01572844657b852334626978 Mon Sep 17 00:00:00 2001 From: catcherwong Date: Fri, 4 Aug 2023 06:36:18 +0000 Subject: [PATCH 2/2] fix dotnet-format error Signed-off-by: catcherwong --- csharp/rocketmq-client-csharp/Signature.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/csharp/rocketmq-client-csharp/Signature.cs b/csharp/rocketmq-client-csharp/Signature.cs index 750aae852..ea701d161 100644 --- a/csharp/rocketmq-client-csharp/Signature.cs +++ b/csharp/rocketmq-client-csharp/Signature.cs @@ -60,7 +60,7 @@ public static Dictionary Sign(Client client) var secretData = Encoding.ASCII.GetBytes(credentials.AccessSecret); var data = Encoding.ASCII.GetBytes(time); using (var signer = new HMACSHA1(secretData)) - { + { var digest = signer.ComputeHash(data); var hmac = BitConverter.ToString(digest).Replace("-", ""); var authorization = $"{MetadataConstants.AlgorithmKey} " +