[Improve][CDC][MySQL] Ennable binlog watermark compare (#4293)

apache · Mar 6, 2023 · b22fb25 · b22fb25
1 parent a55f741
commit b22fb25
Showing 1 changed file with 2 additions and 7 deletions.
diff --git a/...unnel/connectors/seatunnel/cdc/mysql/source/reader/fetch/scan/MySqlSnapshotFetchTask.java b/...unnel/connectors/seatunnel/cdc/mysql/source/reader/fetch/scan/MySqlSnapshotFetchTask.java
@@ -75,13 +75,8 @@ public void execute(FetchTask.Context context) throws Exception {
 
         // optimization that skip the binlog read when the low watermark equals high
         // watermark
-
-        // TODO make binlogBackfillRequired configable.
-        // TODO we need store the data in disk to ensure no memory overflow
-        // final boolean binlogBackfillRequired =
-        //
-        // backfillBinlogSplit.getStopOffset().isAfter(backfillBinlogSplit.getStartupOffset());
-        final boolean binlogBackfillRequired = false;
+        final boolean binlogBackfillRequired =
+                backfillBinlogSplit.getStopOffset().isAfter(backfillBinlogSplit.getStartupOffset());
         if (!binlogBackfillRequired) {
             dispatchBinlogEndEvent(
                     backfillBinlogSplit,