Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][UT] Upgrade junit to 5.+ #2283

Closed
3 tasks done
ashulin opened this issue Jul 28, 2022 · 5 comments
Closed
3 tasks done

[Improve][UT] Upgrade junit to 5.+ #2283

ashulin opened this issue Jul 28, 2022 · 5 comments
Assignees

Comments

@ashulin
Copy link
Member

ashulin commented Jul 28, 2022

Search before asking

  • I had searched in the feature and found no similar feature requirement.

Description

Right now, we still use junit 4.+ in our repo, I hope we can upgrade to Junit 5.+, then we can easy to write the UT, JUnit 5 provide some useful feature, e.g. @ParameterizedTest, @EnabledOnOs,...

Currently we have a small number of test cases and it is easy to upgrade dependencies.

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@ashulin
Copy link
Member Author

ashulin commented Jul 28, 2022

CC @Hisoka-X @CalvinKirs @ruanwenjun

@ashulin ashulin changed the title [Improve[UT] Upgrade junit to 5.+ [Improve][UT] Upgrade junit to 5.+ Jul 28, 2022
@CalvinKirs
Copy link
Member

+1,5 have many highlights

@EricJoy2048
Copy link
Member

+1

@ruanwenjun
Copy link
Member

+1, it would be great if we can upgrade to junit 5+

@ashulin
Copy link
Member Author

ashulin commented Jul 31, 2022

Because Testcontainers are tightly coupled with JUnit4, we can't completely remove junit4, maybe we need a check style rule to banned the import of junit4 class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants