Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improve][E2E] Reactor jdbc e2e with new api. #4165

Merged
merged 1 commit into from
Mar 8, 2023
Merged

[Improve][E2E] Reactor jdbc e2e with new api. #4165

merged 1 commit into from
Mar 8, 2023

Conversation

FlechazoW
Copy link
Contributor

@FlechazoW FlechazoW commented Feb 20, 2023 •
edited
Loading

Purpose of this pull request

Reactor jdbc e2e with new api.

Check list

@TyrantLucifer
Copy link
Member

Good job, let's waiting CICD.

@liugddx
Copy link
Member

liugddx commented Feb 20, 2023

Great pr. Please fix the problem of ci.

@FlechazoW FlechazoW force-pushed the jdbc_e2e branch 6 times, most recently from 05eafea to c2c4767 Compare February 21, 2023 15:47
@FlechazoW
Copy link
Contributor Author

All test has passed. cc, please @TyrantLucifer @liugddx

@FlechazoW FlechazoW changed the title [Improve][E2E] Reactor jdbc e2e with new api. [WIP][E2E] Reactor jdbc e2e with new api. Feb 23, 2023
@FlechazoW
Copy link
Contributor Author

Miss some cases, WIP.

liugddx
liugddx reviewed Feb 23, 2023
View reviewed changes
Copy link
Member

@liugddx liugddx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ic4y PTAL

@FlechazoW FlechazoW force-pushed the jdbc_e2e branch 3 times, most recently from 4ba427a to b1696ea Compare February 28, 2023 15:38
@FlechazoW FlechazoW changed the title [WIP][E2E] Reactor jdbc e2e with new api. [Improve][E2E] Reactor jdbc e2e with new api. Feb 28, 2023
@FlechazoW FlechazoW force-pushed the jdbc_e2e branch 12 times, most recently from 5523a53 to 9f34d9e Compare March 7, 2023 08:03
TyrantLucifer
TyrantLucifer previously approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@TyrantLucifer TyrantLucifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @EricJoy2048 @Hisoka-X

EricJoy2048
EricJoy2048 previously approved these changes Mar 7, 2023
View reviewed changes
@FlechazoW
[Improve][E2E][Jdbc] Reactor jdbc e2e with new api, then remove the u…
d0f0e70 
…seless e2e case. For better performance, we split the jdbc e2e module into three modules.
@FlechazoW FlechazoW dismissed stale reviews from EricJoy2048 and TyrantLucifer via d0f0e70 March 7, 2023 10:47
@FlechazoW
Copy link
Contributor Author

PTAL. @TyrantLucifer @EricJoy2048

TyrantLucifer
TyrantLucifer approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@TyrantLucifer TyrantLucifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @EricJoy2048

@TyrantLucifer TyrantLucifer merged commit 5c689e9 into apache:dev Mar 8, 2023
@FlechazoW FlechazoW deleted the jdbc_e2e branch March 8, 2023 06:28
@TyrantLucifer TyrantLucifer mentioned this pull request Mar 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liugddx liugddx liugddx left review comments

@EricJoy2048 EricJoy2048 EricJoy2048 approved these changes

@TyrantLucifer TyrantLucifer TyrantLucifer approved these changes

Assignees
No one assigned
Labels
approved reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FlechazoW @TyrantLucifer @liugddx @EricJoy2048