Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][CDC][MySQL] Ennable binlog watermark compare #4293

Merged
merged 1 commit into from
Mar 6, 2023
Merged

[Improve][CDC][MySQL] Ennable binlog watermark compare #4293

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions ...unnel/connectors/seatunnel/cdc/mysql/source/reader/fetch/scan/MySqlSnapshotFetchTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,13 +75,8 @@ public void execute(FetchTask.Context context) throws Exception {

// optimization that skip the binlog read when the low watermark equals high
// watermark

// TODO make binlogBackfillRequired configable.
// TODO we need store the data in disk to ensure no memory overflow
// final boolean binlogBackfillRequired =
//
// backfillBinlogSplit.getStopOffset().isAfter(backfillBinlogSplit.getStartupOffset());
final boolean binlogBackfillRequired = false;
final boolean binlogBackfillRequired =
backfillBinlogSplit.getStopOffset().isAfter(backfillBinlogSplit.getStartupOffset());
if (!binlogBackfillRequired) {
dispatchBinlogEndEvent(
backfillBinlogSplit,
Expand Down