Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore][Zeta] Remove redundant code #4489

Merged
merged 2 commits into from
Apr 4, 2023
+3 −6
Merged

[Chore][Zeta] Remove redundant code #4489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0f4cee
[Chore][Zeta] Remove redundant code
TyrantLucifer Apr 3, 2023
d31c932
[Chore][Zeta] Remove redundant code & fix code style
TyrantLucifer Apr 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...c/main/java/org/apache/seatunnel/core/starter/seatunnel/command/ClientExecuteCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ public void execute() throws CommandExecuteException {
StringUtils.isNotEmpty(clusterName)
? clusterName
: Constant.DEFAULT_SEATUNNEL_CLUSTER_NAME);
instance = createServerInLocal(clusterName);
instance = createServerInLocal(clusterName, seaTunnelConfig);
}
if (StringUtils.isNotEmpty(clusterName)) {
seaTunnelConfig.getHazelcastConfig().setClusterName(clusterName);
Expand Down Expand Up @@ -227,8 +227,8 @@ private void closeClient() {
}
}

private HazelcastInstance createServerInLocal(String clusterName) {
SeaTunnelConfig seaTunnelConfig = ConfigProvider.locateAndGetSeaTunnelConfig();
private HazelcastInstance createServerInLocal(
String clusterName, SeaTunnelConfig seaTunnelConfig) {
seaTunnelConfig.getHazelcastConfig().setClusterName(clusterName);
return HazelcastInstanceFactory.newHazelcastInstance(
seaTunnelConfig.getHazelcastConfig(),
Expand Down
3 changes: 0 additions & 3 deletions ...unnel-engine-client/src/main/java/org/apache/seatunnel/engine/client/SeaTunnelClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@

package org.apache.seatunnel.engine.client;

import org.apache.seatunnel.shade.com.fasterxml.jackson.databind.ObjectMapper;

import org.apache.seatunnel.common.utils.JsonUtils;
import org.apache.seatunnel.engine.client.job.JobClient;
import org.apache.seatunnel.engine.client.job.JobExecutionEnvironment;
Expand All @@ -41,7 +39,6 @@
import java.util.Set;

public class SeaTunnelClient implements SeaTunnelClientInstance {
private static final ObjectMapper OBJECT_MAPPER = new ObjectMapper();
private final SeaTunnelHazelcastClient hazelcastClient;
@Getter private final JobClient jobClient;

Expand Down