Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hotfix][SQL Transform] Fix cast to timestamp, date, time bug #5812

Merged
merged 3 commits into from
Nov 27, 2023
Merged

[Hotfix][SQL Transform] Fix cast to timestamp, date, time bug #5812

merged 3 commits into from
Nov 27, 2023

Conversation

EricJoy2048
Copy link
Member

Purpose of this pull request

Fix #5809

Does this PR introduce any user-facing change?

No

How was this patch tested?

Add e2e test already.

Check list

Hisoka-X
Hisoka-X previously approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if test passed.

@Hisoka-X Hisoka-X added this to the 2.3.4 milestone Nov 8, 2023
@Hisoka-X
Copy link
Member

Hisoka-X commented Nov 8, 2023

cc @rewerma

@hailin0
Copy link
Member

hailin0 commented Nov 8, 2023

LGTM

waiting for ci passed

@EricJoy2048 EricJoy2048 force-pushed the 155_fix_sql_cast_error branch 2 times, most recently from bd895d8 to c58218e Compare November 8, 2023 08:40
@hailin0
Copy link
Member

hailin0 commented Nov 8, 2023

image

@EricJoy2048 EricJoy2048 force-pushed the 155_fix_sql_cast_error branch from c58218e to d28c9fa Compare November 8, 2023 09:36
@EricJoy2048
Copy link
Member Author

image

fixed

@EricJoy2048 EricJoy2048 force-pushed the 155_fix_sql_cast_error branch from 24d5d85 to 1f079c7 Compare November 10, 2023 07:57
@EricJoy2048 EricJoy2048 force-pushed the 155_fix_sql_cast_error branch from 1f079c7 to 60978b9 Compare November 27, 2023 02:33
@hailin0 hailin0 merged commit de181de into apache:dev Nov 27, 2023
alextinng pushed a commit to alextinng/seatunnel that referenced this pull request Dec 19, 2023
@EricJoy2048
[Hotfix][SQL Transform] Fix cast to timestamp, date, time bug (apache…
81f81fd 
…#5812)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hailin0 hailin0 hailin0 approved these changes

@Hisoka-X Hisoka-X Hisoka-X approved these changes

Assignees
No one assigned
Labels
approved bug reviewed SQL Transform
Projects
None yet
Milestone
2.3.4
Development

Successfully merging this pull request may close these issues.

[Bug] [SQL Transform] Cast bigint to timestamp error
3 participants
@EricJoy2048 @Hisoka-X @hailin0