Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix Debezium format cannot parse date/time/timestamp #5887

Merged
merged 7 commits into from
Dec 14, 2023

Conversation

Hisoka-X
Copy link
Member

Purpose of this pull request

This PR fix Debezium format cannot parse date/time/timestamp when read from kafka use debezium_json format.

Does this PR introduce any user-facing change?

no

How was this patch tested?

add new test.

Check list

@Hisoka-X Hisoka-X force-pushed the fix-COMPATIBLE_DEBEZIUM_JSON branch from 7f96b3e to 66a8eaa Compare November 21, 2023 05:54
@Hisoka-X Hisoka-X force-pushed the fix-COMPATIBLE_DEBEZIUM_JSON branch from 66a8eaa to 0c8f73a Compare November 21, 2023 05:56
@Hisoka-X
Copy link
Member Author

cc @hailin0 @zhilinli123

@zhilinli123
Copy link
Contributor

zhilinli123 commented Nov 27, 2023

Good,pr e2e LGTM, by the way a small suggestion can be appropriately added Mysql e2e DDL and INSERT information can be listed as a reference basis, other e2e formats do the same way so that it is more uniform and simpler
@Hisoka-X

@Hisoka-X
Copy link
Member Author

Good,pr e2e LGTM, by the way a small suggestion can be appropriately added Mysql e2e DDL and INSERT information can be listed as a reference basis, other e2e formats do the same way so that it is more uniform and simpler @Hisoka-X

done

hailin0
hailin0 previously approved these changes Nov 28, 2023
# Conflicts:
#	seatunnel-formats/seatunnel-format-json/src/main/java/org/apache/seatunnel/format/json/debezium/DebeziumJsonFormatFactory.java
Copy link
Member

@Carl-Zhou-CN Carl-Zhou-CN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hailin0 hailin0 merged commit d4caef7 into apache:dev Dec 14, 2023
alextinng pushed a commit to alextinng/seatunnel that referenced this pull request Dec 19, 2023
@Hisoka-X Hisoka-X deleted the fix-COMPATIBLE_DEBEZIUM_JSON branch December 27, 2023 03:05
chaorongzhi pushed a commit to chaorongzhi/seatunnel that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants