Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] Replace SeaTunnelRowType with TableSchema in the JdbcRowConverter #5957

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

ic4y
Copy link
Contributor

@ic4y ic4y commented Dec 4, 2023

Purpose of this pull request

To achieve more precise control over JDBC write and read operations, this pull request proposes replacing the SeaTunnelRowType with TableSchema in the JdbcRowConverter interface. TableSchema provides more detailed information, such as the length information or column type, which can be utilized to determine whether to use stmt.setString(str) or stmt.setClob(1, clob) when writing String types.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

The existing tests are sufficient to cover it.

Check list

@hailin0
Copy link
Member

hailin0 commented Dec 5, 2023

image

@Hisoka-X Hisoka-X changed the title [feature][connector-jdbc] Replace SeaTunnelRowType with TableSchema in the JdbcRowConverter [Improve] Replace SeaTunnelRowType with TableSchema in the JdbcRowConverter Dec 5, 2023
@Hisoka-X
Copy link
Member

Hisoka-X commented Dec 5, 2023

image

+1

@ic4y
Copy link
Contributor Author

ic4y commented Dec 5, 2023

The PR description has been updated.

@Hisoka-X Hisoka-X merged commit 1cc1b1b into apache:dev Dec 5, 2023
@hailin0 hailin0 mentioned this pull request Dec 16, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants