Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improve][Connector-V2] Replace CommonErrorCodeDeprecated.JSON_OPERATION_FAILED #5978

Merged
merged 1 commit into from
Dec 23, 2023
Merged

[Improve][Connector-V2] Replace CommonErrorCodeDeprecated.JSON_OPERATION_FAILED #5978

merged 1 commit into from
Dec 23, 2023

Conversation

CheneyYin
Copy link
Contributor

@CheneyYin CheneyYin commented Dec 7, 2023 •
edited
Loading

Purpose of this pull request

Replace CommonErrorCodeDeprecated.JSON_OPERATION_FAILED
Related:

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@CheneyYin CheneyYin mentioned this pull request Dec 7, 2023
Closed
7 tasks
@CheneyYin CheneyYin force-pushed the connector-error-json-op branch 2 times, most recently from be08af8 to e54f704 Compare December 20, 2023 14:34
@CheneyYin CheneyYin marked this pull request as ready for review December 21, 2023 02:16
@CheneyYin
Copy link
Contributor Author

PTAL @Hisoka-X @hailin0

Hisoka-X
Hisoka-X reviewed Dec 21, 2023
View reviewed changes
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should change json error msg from

JSON_OPERATION_FAILED("COMMON-02", "<format> JSON convert/parse '<payload>' operation failed.")

to

JSON_OPERATION_FAILED("COMMON-02", "<identifier> JSON convert/parse '<payload>' operation failed.")

@CheneyYin
Copy link
Contributor Author

I think we should change json error msg from

JSON_OPERATION_FAILED("COMMON-02", "<format> JSON convert/parse '<payload>' operation failed.")

to

JSON_OPERATION_FAILED("COMMON-02", "<identifier> JSON convert/parse '<payload>' operation failed.")

Agree

@CheneyYin CheneyYin force-pushed the connector-error-json-op branch from e54f704 to a6f12cf Compare December 21, 2023 10:32
@CheneyYin CheneyYin force-pushed the connector-error-json-op branch from a6f12cf to 86ad554 Compare December 22, 2023 08:00
@hailin0 hailin0 merged commit 456cd17 into apache:dev Dec 23, 2023
2 checks passed
@CheneyYin CheneyYin deleted the connector-error-json-op branch December 23, 2023 22:54
alextinng pushed a commit to alextinng/seatunnel that referenced this pull request Dec 26, 2023
@CheneyYin
[Improve][Connector-V2] Replace CommonErrorCodeDeprecated.JSON_OPERAT…
14312c4 
…ION_FAILED (apache#5978)
chaorongzhi pushed a commit to chaorongzhi/seatunnel that referenced this pull request Aug 21, 2024
@CheneyYin
[Improve][Connector-V2] Replace CommonErrorCodeDeprecated.JSON_OPERAT…
7cd4710 
…ION_FAILED (apache#5978)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hailin0 hailin0 hailin0 approved these changes

@Hisoka-X Hisoka-X Hisoka-X approved these changes

Assignees
No one assigned
Labels
approved reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CheneyYin @hailin0 @Hisoka-X