-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug][Improve][Connector-v2][ElasticsearchSource] Fix behavior when source empty,Support SourceConfig.SOURCE field empty. #6425
Conversation
[Improve][Connector-v2][ElasticsearchSource] Support SourceConfig.SOURCE field empty.
@iture123 @TyrantLucifer @Hisoka-X PTAL,thanks. |
...st/java/org/apache/seatunnel/connectors/seatunnel/elasticsearch/ElasticsearchSourceTest.java
Outdated
Show resolved
Hide resolved
I think we should add a e2e test case in Line 68 in 045d3e3
|
[Improve][Connector-v2][ElasticsearchSource] Support SourceConfig.SOURCE field empty.
...nel/connectors/seatunnel/elasticsearch/serialize/source/DefaultSeaTunnelRowDeserializer.java
Outdated
Show resolved
Hide resolved
…ource empty,Support SourceConfig.SOURCE field empty.
@iture123 @TyrantLucifer @Hisoka-X PTAL,thanks. |
Hi @CosmosNi , thanks for add test! Could you retry the test case after merge from dev? |
@Hisoka-X I don't understand. Can you show me how to operate it? |
@Hisoka-X already merge code from upstream,PTAL,thanks. |
[Improve][Connector-v2][ElasticsearchSource] Support SourceConfig.SOURCE field empty.
[Improve][Connector-v2][ElasticsearchSource] Support SourceConfig.SOURCE field empty.
[Improve][Connector-v2][ElasticsearchSource] Support SourceConfig.SOURCE field empty.
[Improve][Connector-v2][ElasticsearchSource] Support SourceConfig.SOURCE field empty.
[Improve][Connector-v2][ElasticsearchSource] Support SourceConfig.SOURCE field empty.
[Improve][Connector-v2][ElasticsearchSource] Support SourceConfig.SOURCE field empty.
[Improve][Connector-v2][ElasticsearchSource] Support SourceConfig.SOURCE field empty.
[Improve][Connector-v2][ElasticsearchSource] Support SourceConfig.SOURCE field empty.
[Improve][Connector-v2][ElasticsearchSource] Support SourceConfig.SOURCE field empty.
[Improve][Connector-v2][ElasticsearchSource] Support SourceConfig.SOURCE field empty.
@Hisoka-X i add a label (array_column) to handle es array type,PTAL,thanks. |
@Hisoka-X @hailin0 @EricJoy2048 PTAL,thanks. |
...java/org/apache/seatunnel/connectors/seatunnel/elasticsearch/source/ElasticsearchSource.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Hisoka-X sorry,I accidentally removed label. |
…ource empty,Support SourceConfig.SOURCE field empty. (apache#6425)
[Improve][Connector-v2][ElasticsearchSource] Support SourceConfig.SOURCE field empty.
Purpose of this pull request
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note
.