[Feature][Tool] Add connector check script for issue 6199 #6635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @Hisoka-X |
3 tasks
|
good pr |
hailin0
reviewed
Apr 7, 2024
|
good pr |
Hisoka-X
reviewed
Apr 7, 2024
seatunnel-core/seatunnel-starter/src/main/bin/seatunnel-connector.cmd
Outdated
Show resolved
Hide resolved
...n-discovery/src/main/java/org/apache/seatunnel/plugin/discovery/AbstractPluginDiscovery.java
Outdated
Show resolved
Hide resolved
...el-plugin-discovery/src/main/java/org/apache/seatunnel/plugin/discovery/PluginDiscovery.java
Outdated
Show resolved
Hide resolved
dailai
force-pushed
the
support-check-script-of-connector
branch
from
19cf30c to
63be624
Compare
Hisoka-X
reviewed
Apr 8, 2024
...er-e2e/src/test/java/org/apache/seatunnel/core/starter/seatunnel/SeaTunnelConnectorTest.java
Outdated
Show resolved
Hide resolved
...er-e2e/src/test/java/org/apache/seatunnel/core/starter/seatunnel/SeaTunnelConnectorTest.java
Outdated
Show resolved
Hide resolved
dailai
force-pushed
the
support-check-script-of-connector
branch
from
8f4c783 to
89826f7
Compare
Hisoka-X
reviewed
Apr 9, 2024
...er-e2e/src/test/java/org/apache/seatunnel/core/starter/seatunnel/SeaTunnelConnectorTest.java
Outdated
Show resolved
Hide resolved
|
|
|
@dailai could you retrigger the ci? |
Please wait a minute. |
dailai
force-pushed
the
support-check-script-of-connector
branch
from
b7b8ab5 to
b284da0
Compare
hailin0
reviewed
Apr 9, 2024
Comment on lines
+56
to
+57
| type = {EngineType.SPARK, EngineType.FLINK}, | ||
| disabledReason = "Only support for seatunnel") |
There was a problem hiding this comment.
Why is it tied to the execution engine? There seems to be no strong correlation
There was a problem hiding this comment.
Why is it tied to the execution engine? There seems to be no strong correlation
It really does not matter, but since it is to check the connector and transform of seatunnel, we only need to use the container of seatunnel to run the e2e test.
chaorongzhi
pushed a commit
to chaorongzhi/seatunnel
that referenced
this pull request
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
[Feature][Tool] Add connector check script #6199
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.