-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix][KuduCatalogFactory]: Fix KuduCatalogFactory.optionRule() will throw an Exception #6787
Conversation
…ow an Exception Fix `KuduCatalogFactory.optionRule()` will throw an Exception because conditional OptionRule should be in the optinal or required options.
@Jetiaime hi, Follow these steps to resolve the error |
same as #6788 (comment) |
Could you add test case like Line 26 in 4d9287f
|
1. Add a Test On KuduFactory
thx, test has been added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if ci passed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
…hrow an Exception (apache#6787) * fix(KuduCatalogFactory): Fix KuduCatalogFactory.optionRule() will throw an Exception Fix `KuduCatalogFactory.optionRule()` will throw an Exception because conditional OptionRule should be in the optinal or required options. * [Feat][KuduFactoryTest]: Add a Test On KuduFactory 1. Add a Test On KuduFactory
Purpose of this pull request
Fix
KuduCatalogFactory.optionRule()
will throw an Exception because conditional OptionRule should be in the optinal or required options.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Covered By the Tests
Check list
New License Guide
release-note
.