Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improve][Engine] Support custom job id for rest-api named submit-job #7053

Merged
merged 3 commits into from
Jun 25, 2024
Merged

[Improve][Engine] Support custom job id for rest-api named submit-job #7053

merged 3 commits into from
Jun 25, 2024

Conversation

dailai
Copy link
Contributor

@dailai dailai commented Jun 24, 2024

Purpose of this pull request

For issue #6968

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@dailai
Copy link
Contributor Author

dailai commented Jun 24, 2024

@Hisoka-X @hailin0 PTAL

@Hisoka-X Hisoka-X added this to the 2.3.6 milestone Jun 24, 2024
@dailai dailai force-pushed the support-jobId-for-submitJob-rest-api branch from e2c9768 to b5813ca Compare June 25, 2024 02:45
@dailai dailai requested a review from Hisoka-X June 25, 2024 03:28
@Hisoka-X Hisoka-X linked an issue Jun 25, 2024 that may be closed by this pull request
[Feature][Rest] Support set job id when use rest api to submit job #6968
Closed
3 tasks
Hisoka-X
Hisoka-X reviewed Jun 25, 2024
View reviewed changes
...tunnel-e2e-base/src/test/java/org/apache/seatunnel/engine/e2e/ClusterSeaTunnelContainer.java
@@ -101,106 +103,24 @@ public void tearDown() throws Exception {
}

@Test
public void testSubmitJob() {
public void testSubmitJobWithCustomJobId() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @liugddx as well

Hisoka-X
Hisoka-X approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EricJoy2048 EricJoy2048 merged commit 77f6140 into apache:dev Jun 25, 2024
6 checks passed
Thomas-HuWei pushed a commit to zilliztech/seatunnel that referenced this pull request Jul 10, 2024
@dailai @Thomas-HuWei
[Improve][Engine] Support custom job id for rest-api named submit-job (…
0f3ed14 
…apache#7053)
@dailai dailai deleted the support-jobId-for-submitJob-rest-api branch August 1, 2024 00:43
chaorongzhi pushed a commit to chaorongzhi/seatunnel that referenced this pull request Aug 21, 2024
@dailai
[Improve][Engine] Support custom job id for rest-api named submit-job (…
a10aff9 
…apache#7053)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricJoy2048 EricJoy2048 EricJoy2048 approved these changes

@Hisoka-X Hisoka-X Hisoka-X approved these changes

Assignees
No one assigned
Labels
approved improve reviewed Zeta
Projects
None yet
Milestone
2.3.6
Development

Successfully merging this pull request may close these issues.

[Feature][Rest] Support set job id when use rest api to submit job
3 participants
@dailai @EricJoy2048 @Hisoka-X