Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(storage-node): add reconcile logic #293

Merged
merged 1 commit into from
Apr 13, 2023
Merged

feat(storage-node): add reconcile logic #293

merged 1 commit into from
Apr 13, 2023

Conversation

Xu-Wentao
Copy link
Collaborator

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

  • implement storage node reconcile logic
  • support aws-aurora database

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?

@Xu-Wentao Xu-Wentao mentioned this pull request Apr 4, 2023
Closed
@Xu-Wentao
Copy link
Collaborator Author

this issue resolve the problem about controller-runtime install crd failed.

@mlycore mlycore added type: enhancement New feature or request operator solutions of operator in: feature labels Apr 5, 2023
@mlycore mlycore added this to the 0.3.0 milestone Apr 5, 2023
@mlycore
Copy link
Contributor

mlycore commented Apr 7, 2023

Please change the remote branch to feat-storagenode

@Xu-Wentao Xu-Wentao force-pushed the feat/storage-node branch 2 times, most recently from 3cc0c29 to 2c4daf8 Compare April 7, 2023 11:30
mlycore
mlycore previously approved these changes Apr 7, 2023
View reviewed changes
@Xu-Wentao Xu-Wentao force-pushed the feat/storage-node branch 5 times, most recently from a1f19c8 to e69f013 Compare April 12, 2023 10:17
@Xu-Wentao Xu-Wentao changed the title WIP: feat(storage-node): add reconcile logic feat(storage-node): add reconcile logic Apr 12, 2023
@Xu-Wentao Xu-Wentao force-pushed the feat/storage-node branch 2 times, most recently from e878450 to 082fe57 Compare April 13, 2023 05:52
@Xu-Wentao Xu-Wentao changed the base branch from main to feat-storagenode April 13, 2023 06:00
@Xu-Wentao
Copy link
Collaborator Author

Please change the remote branch to feat-storagenode

done!

@Xu-Wentao Xu-Wentao force-pushed the feat/storage-node branch 2 times, most recently from 85f68d2 to 5664052 Compare April 13, 2023 06:31
@mlycore mlycore merged commit 95dd805 into apache:feat-storagenode Apr 13, 2023
Xu-Wentao added a commit to Xu-Wentao/shardingsphere-on-cloud that referenced this pull request May 5, 2023
@Xu-Wentao
feat(storage-node): add reconcile logic (apache#293)
c91a75d
Xu-Wentao added a commit to Xu-Wentao/shardingsphere-on-cloud that referenced this pull request May 6, 2023
@Xu-Wentao
feat(storage-node): add reconcile logic (apache#293)
8f3b017
Xu-Wentao added a commit to Xu-Wentao/shardingsphere-on-cloud that referenced this pull request May 6, 2023
@Xu-Wentao
feat(storage-node): add reconcile logic (apache#293)
9e0174b
Xu-Wentao added a commit to Xu-Wentao/shardingsphere-on-cloud that referenced this pull request May 6, 2023
@Xu-Wentao
feat(storage-node): add reconcile logic (apache#293)
c8f5ea7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlycore mlycore mlycore requested changes

Assignees
No one assigned
Labels
in: feature operator solutions of operator type: enhancement New feature or request
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Xu-Wentao @mlycore